Bug 154424 - Tray menu: toggle Open and Close
Summary: Tray menu: toggle Open and Close
Status: VERIFIED FIXED
Alias: None
Product: kleopatra
Classification: Applications
Component: general (show other bugs)
Version: outdated (old bug dump)
Platform: Compiled Sources Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Marc Mutz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-21 10:35 UTC by Jan-Oliver Wagner
Modified: 2008-10-23 17:44 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan-Oliver Wagner 2007-12-21 10:35:43 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                MS Windows

The tray menu has an entry
"Open Certificate Manager ..."
which is correct when the main window is currently
closed.
When it is open, this action will in fact close the window.

It would be really cool if the menu item text changes (toggles)
according to the status ("Close Certficate Manager ...").
Comment 1 Jan-Oliver Wagner 2008-01-10 15:59:10 UTC
Still the same behaviour. Would appreciate consideration.
Comment 2 Marc Mutz 2008-01-22 16:59:46 UTC
I've changed it such that the action is disabled instead. Close is a bit a misnomer, and I didn't want to confuse the user with two shutdown/close options in one menu.
Comment 3 Jan-Oliver Wagner 2008-02-01 09:37:15 UTC
Perhaps "Hide" is a better term?

Current problem is that a single LMB click on the Kleo icon in the tray
area still performs the "hide" action while it is no more possible with
the menu.

Hiding the window (it is not even in the taskbar) is nice in principle,
and should work consistently.
Comment 4 Marc Mutz 2008-02-01 14:55:42 UTC
Well, you can say File->Close in the main window to close it.
Apart from the fact that the Open action actually closed the window if it was open, would you really expect to find a close window action in a tray icon's context menu?

I can disable the LMB click when the window is open, or make it raise the window instead. How about that?
Comment 5 Jan-Oliver Wagner 2008-02-01 15:05:42 UTC
LMB clicking on it and always raise the window is probably
suitable with user understanding.
Comment 6 Marc Mutz 2008-02-07 11:03:01 UTC
SVN commit 771953 by mutz:

Un-iconify, un-hide, and stack-to-top the main window on tray icon click.

BUG: 154424

 M  +18 -11    systemtrayicon.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=771953