Bug 154315 - Generic Icon crashes plasma
Summary: Generic Icon crashes plasma
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR crash
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-19 13:01 UTC by Gabriel C
Modified: 2007-12-19 18:34 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
backtrace (6.22 KB, text/plain)
2007-12-19 17:53 UTC, Simon St James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel C 2007-12-19 13:01:10 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 4.2.2 
OS:                Linux

Hi,

while playing with the widgets I found by accident a way to crash plasma with the generic icon.

To reproduce do :

Add Widgets -> ( add the Generic Icon ) 

On the desktop go to configure the Icon , type some text in the empty box ( does not matter what ) , type ok button and plasma crashes.

Gdb does not give me any backtrace all I have here before the crash is :

...

plasma(2300)/kdecore (trader) KMimeTypeTrader::weightedOffers: KMimeTypeTrader::weightedOffers(  "application/octet-stream" ,  "KPropertiesDialog/Plugin"  )
plasma(2300)/kdecore (trader) KMimeTypeTrader::query: query for mimeType  "application/octet-stream" ,  "KPropertiesDialog/Plugin"  : returning  0  offers
Task added, isActive =  false
ASSERT: "i >= 0 && i < size()" in file /usr/include/QtCore/qstring.h, line 636

...

and from dmesg :

plasma[25012]: segfault at 0af40b35 eip 0af40b35 esp bfea3ecc error 4
klauncher[19587]: segfault at b7ef8344 eip b75eafa8 esp bfb1bb40 error 7

( that may  be because my ECC RAM and NX bit but still indicates something is wrong )

Regards , 

Gabriel
Comment 1 Marco Martin 2007-12-19 13:39:57 UTC
Can confirm, KPropertiesDialog() of an empty url makes bad things
i think if the url is empty or invalid it should be opened another config dialog that asks for a right url
Comment 2 Dan Meltzer 2007-12-19 17:11:43 UTC
I'm thinking that perhaps the icon should not be addable on its own, but should be created in the background whenever a link is dropped on the desktop?
Comment 3 Riccardo Iaconelli 2007-12-19 17:19:56 UTC
On 19 Dec 2007 16:11:44 -0000, Dan Meltzer
<hydrogen@notyetimplemented.com> wrote:
[bugs.kde.org quoted mail]
Comment 4 Marco Martin 2007-12-19 17:38:21 UTC
yeah, this could be a way to do and if the icon applet is going to be the "classical" icon desktopits behaviour should be changed a little bit (and with a "little bit" i mean an awful lot), in particular:
-should a file drop on the desktop actually copy the file o the desktop?
-should deleting an icon applet actually delete the file from the desktop?
-now dropping a file on another icon causes the applet to load the url dropped: maybe it should behave like in a filemanager view ie if it's a folder copy the file in thet folder and if it's a desktop file of an app start the app with the dropped url as param
Comment 5 Simon St James 2007-12-19 17:53:03 UTC
Created attachment 22624 [details]
backtrace

Backtrace, if anyone is interested.
Comment 6 Aaron J. Seigo 2007-12-19 18:18:24 UTC
-should a file drop on the desktop actually copy the file o the desktop? 

this actually is a meaningless question with plasma. we show the icons in the ~/Desktop folder as an option, but the idea of having a desktop storage area is something we're leaving behind. there is no "location" associated with the desktop itself. folder plasmoids will provide such functionality, but the desktop itself should remain locationless.

 -should deleting an icon applet actually delete the file from the desktop? 

only if it is an icon that came from the ~/Desktop folder in the first place.

 -now dropping a file on another icon causes the applet to load the url dropped: maybe it should behave like in a filemanager view ie if it's a folder copy the file in thet folder and if it's a desktop file of an app start the app with the dropped url as param 
 
yes.

these discussions probably belong on panel-devel@kde.org rather than on this BR however.
Comment 7 Aaron J. Seigo 2007-12-19 18:34:09 UTC
SVN commit 750599 by aseigo:

don't crash when dealing with an empty string
BUG:154315


 M  +1 -1      kpropertiesdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=750599