Bug 153830 - comments don't load in sfgate.com
Summary: comments don't load in sfgate.com
Status: RESOLVED WORKSFORME
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-11 10:42 UTC by A. Spehr
Modified: 2008-11-10 10:53 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description A. Spehr 2007-12-11 10:42:36 UTC
Version:           3.5.8 (using KDE KDE 3.5.8)
Installed from:    Ubuntu Packages
OS:                Linux

Right below the gray box, you'll see "Loading...", except it never loads.
Logged in or not, it doesn't load.

Verified by several people on #kde-devel to be in later versions of Konqueror.

A random sample url:
http://www.sfgate.com/cgi-bin/article/comments/view?f=/c/a/2007/12/10/MNBQTRIQQ.DTL
Comment 1 Rolf Eike Beer 2007-12-11 11:45:48 UTC
Looks like loading the comments is done with Javascript so this might belong there.
Comment 2 Charles Samuels 2007-12-12 08:14:24 UTC
http://www.schizofreend.nl/Pork.Iframe/

this strange library is the culprit...
Comment 3 Charles Samuels 2007-12-12 10:08:47 UTC
this line isn't taking effect:
frame.addEventListener("load", 	function(){	this.onStateChange(); }.bind(this), false);

the frame is loaded, but it doesn't call the event handler.

testcase: http://ktown.kde.org/~charles/proto/hello.html

Looks like the bug rests on calling load for an iframe when it finishes loading
Comment 4 Charles Samuels 2007-12-14 05:58:56 UTC
bahh! no, the event handler is called, I thought it wasn't because I set the inner frame to a different domain in my test case, and konq rejected that for security.
Comment 5 Charles Samuels 2007-12-16 05:36:23 UTC
for the record:

the problem is that load() is called twice for the iframe's onload handler. the event handler is installed outside the iframe, but it's installed on the iframe. And the load is called from the event handler installer, and then again when the load actually happens later. but by then the "Pork" js gets confused.

http://ktown.kde.org/~charles/proto/hello3.html 
Comment 6 Maksim Orlovich 2008-03-31 19:34:01 UTC
Uhm, on carefully reading the testcase, the current behavior is perfectly correct, and IceWeasel agrees. Well, I'll add it to my list of iframe issues...
Comment 7 FiNeX 2008-04-21 13:54:09 UTC
Both sfgate.com and testcase are working right both on 3.5.8 and on konqueror 4 (trunk r797319)
Comment 8 James Spahlinger 2008-04-22 22:04:38 UTC
Mmm, you sure, I just replicated the error in 4.0.3 and 3.5.9.

In the test case Hello shows up twice on the second button click. If this is desired behavior, this bug can be closed, if it is not, the bug is not yet fixed.

I should note that this also occurs in Firefox 3 beta 5.
Comment 9 Christophe Marin 2008-04-22 22:12:00 UTC
Confirmed in trunk (799809). Checked with both testcases in #0 and #5
Comment 10 James Spahlinger 2008-04-22 22:16:51 UTC
Yes, seconding this, confirming the bug. I see it now, its on the webpage proper, not the statusbar. 
Comment 11 FiNeX 2008-04-22 23:13:00 UTC
I've recompiled (r799878). Now both testcase and website are not working correctly :-(
Comment 12 A. Spehr 2008-11-09 21:31:46 UTC
The webpage changed, but the testcase seems to work. Is this closable?
r881723
Comment 13 FiNeX 2008-11-10 10:53:23 UTC
Yes, the testcase works like in other browsers.