Bug 153762 - konversation does not show what is actually sent (encoding)
Summary: konversation does not show what is actually sent (encoding)
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: 1.0.1
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: argonel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-10 03:42 UTC by Daniel Hahler
Modified: 2009-07-23 10:55 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Hahler 2007-12-10 03:42:05 UTC
Version:           1.0.1 (using KDE KDE 3.5.8)
Installed from:    Ubuntu Packages

If Konversation is configured to use iso-8859-1 character set, and if I enter a message with some characters outside this character set, the following seems to happen:
- Konversation silently translates the non-iso-8859-1 characters to "?" when it sends the message to the server.
- However, the chat window, the irc log, etc. show the original message.
Thus, one never knows what the other people actually see, especially if some text is copy-pasted from somewhere else, and it contains characters that look similar to normal iso-8859-1 characters.

I would expect one of the following:
1) Konversation does the translation and shows the result in the chat window.
2) Konversation gives a warning, highlights the problems, and lets me edit the message.

(Bug forwarded from https://bugs.launchpad.net/bugs/60681)
Comment 1 argonel 2008-03-12 19:38:44 UTC
just some background as to why this is happening, for future reference. we let the qtextstream apply the encoding, so the encoded message doesn't exist when the text is added to the ircview. this will not be fixed in 1.1. assigning to me so i don't forget it.
Comment 2 Travis McHenry 2009-07-23 10:55:52 UTC
SVN commit 1001417 by tjmchenry:

Warn the user when they're sending an invalid char for the set encoding
Make it so the ircview shows what gets sent (any '?' replacements)
BUG:153762

 M  +2 -1      config/warnings_config.cpp  
 M  +40 -1     irc/outputfilter.cpp  
 M  +1 -0      irc/outputfilter.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1001417