Bug 153649 - Terminal emulator inside konqueror doesn't work
Summary: Terminal emulator inside konqueror doesn't work
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: 4.0
Platform: Compiled Sources Linux
: NOR major
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 158469 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-12-07 22:29 UTC by Ivo Anjo
Modified: 2009-02-09 21:17 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
openurl implementation (1.70 KB, patch)
2008-08-09 16:37 UTC, David Faure
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ivo Anjo 2007-12-07 22:29:16 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

Clicking window->show terminal emulator on konqueror opens the built-in terminal emulator, but no shell is started.

This happens in both kde4daily version KDESVNTRUNKr745797 and on latest opensuse packages.
Comment 1 FiNeX 2008-02-28 10:42:36 UTC
*** Bug 158469 has been marked as a duplicate of this bug. ***
Comment 2 FiNeX 2008-02-28 10:42:42 UTC
Confirmed even on recent revision (compiled from trunk 2 days ago). 
Comment 3 Caleb Cushing 2008-03-22 01:56:43 UTC
still present in 4.0.2 release 17.2
Comment 4 Caleb Cushing 2008-05-17 09:02:57 UTC
testing on gentoo kde 4.04 still present. I'm hoping this get's fixed by kde 4.1
Comment 5 George Goldberg 2008-05-18 05:21:21 UTC
I get this exact issue using svn trunk r808613 (compiled from source, running on mandriva 2008.1 x86_64).
Comment 6 Dimitrios Glentadakis 2008-07-14 13:40:22 UTC
i have the same bug
mandriva cooker 2009.0 (KDE 4.0.98 (4.1 RC1)
A screenshot :
http://img514.imageshack.us/img514/9923/konqkonsua6.jpg

Comment 7 Maksim Orlovich 2008-07-14 17:24:31 UTC
Seems like Konqueror just creates the konsole KPart, but that it needs to be explicitly told to run the shell via the terminal interface (showShellInDir).

Don't know how to best fix it, since Konqueror's logic is entirely generic --- it has no clue it's opening a terminal emulator. David, could you perhaps take a look? Seems like a fairly important bug to me...

Comment 8 Caleb Cushing 2008-07-29 21:55:26 UTC
still present in 4.1.00 (testing factory on opensuse 11.0). come on guys this has been open since 4.0.1
Comment 9 David Faure 2008-08-09 15:00:30 UTC
This is because the implementation of openUrl has been removed from konsolepart since kde3, I don't know why.

Re-adding an openUrl implementation fixes it. Robert, OK with this patch?
Comment 10 David Faure 2008-08-09 16:37:31 UTC
Created attachment 26755 [details]
openurl implementation
Comment 11 Robert Knight 2008-08-09 17:00:35 UTC
Hi,

Please commit David,

Regards,
Robert.

2008/8/9 David Faure <faure@kde.org>:
[bugs.kde.org quoted mail]
Comment 12 David Faure 2008-08-10 11:08:28 UTC
SVN commit 844692 by dfaure:

Re-add a openUrl implementation so that embedding konsolepart into konqueror works again
BUG: 153649


 M  +32 -7     Part.cpp  
 M  +12 -11    Part.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=844692
Comment 13 Caleb Cushing 2008-10-01 01:05:54 UTC
using a development suse build and this isn't fixed it's based on kde 4.1.2 release 52.2
Comment 14 Ivo Anjo 2008-10-01 14:39:21 UTC
Caleb: The fix has only been applied to trunk, so it should only appear in KDE 4.2 .
Comment 15 Caleb Cushing 2008-10-01 15:17:38 UTC
so you're saying it wouldn't be fixed in the unstable branch that opensuse builds? which I believe is off recent svns. I update last night so I'm running pre-4.2. wouldn't it be fixed in that?

Version 4.1.67 (KDE 4.1.67 (KDE 4.2 >= 20080918)) "release 1.4"
Comment 16 Ivo Anjo 2008-10-01 15:40:53 UTC
I just tried it in my trunk build and it's working fine. openSUSE's must be outdated or something.
Comment 17 FiNeX 2008-10-01 16:07:26 UTC
Confirmed, it is working in trunk.
Comment 18 skraelings001 2009-02-04 21:11:22 UTC
I'd like to note that it doesn't work in web-browser mode. It only does for file-browser mode. I have just upgraded to kde 4.2 from stable tree of gentoo.
Is there a use-case for terminal emulator in web-browser mode? Otherwise it should be removed from menu.
Comment 19 skraelings001 2009-02-04 21:11:48 UTC
I'd like to note that it doesn't work in web-browser mode. It only does for file-browser mode. I have just upgraded to kde 4.2 from stable tree of gentoo.
Is there a use-case for terminal emulator in web-browser mode? Otherwise it should be removed from menu.
Comment 20 David Faure 2009-02-09 21:15:00 UTC
SVN commit 923962 by dfaure:

Make openUrl lead to a useable shell in all cases, even if the url is not a local url.
CCBUG: 153649


 M  +4 -2      Part.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=923962
Comment 21 David Faure 2009-02-09 21:17:01 UTC
It's technically difficult to "remove the menu item if the current view is
HTTP", since the toggleviews are registered once and for all via desktop files.