Bug 153363 - HIG color violations in columnview
Summary: HIG color violations in columnview
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-03 18:39 UTC by Matthew Woehlke
Modified: 2008-01-10 19:25 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Woehlke 2007-12-03 18:39:48 UTC 
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

The column view in dolphin uses non-scheme colors (black, DolphinColumnView::updateColumnsBackground) and uses scheme colors incorrectly (DolphinColumnWidget::updateBackground). Mixing colors from different sets (in this case, window and view) is an HIG violation when done incorrectly as it can lead to illegible results.

A better result might be to blend in some of the foreground color rather than a background color from some other set (or else just use window colors outright).
Comment 1 Peter Penz 2008-01-10 19:25:14 UTC 
SVN commit 759482 by ppenz:

fixed HIG color violations

BUG: 153363

 M  +6 -2      dolphincolumnview.cpp  
 M  +9 -5      dolphincolumnwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=759482