Bug 152619 - Non Scaling Icons in Dolphin
Summary: Non Scaling Icons in Dolphin
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-21 00:04 UTC by Ben Kevan
Modified: 2008-01-16 20:51 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Kevan 2007-11-21 00:04:04 UTC
Version:           3.96.00 (using KDE KDE 3.95.0)
Installed from:    SuSE RPMs
OS:                Linux

Open dolphin click on Home then Documents or Click on Network 

Look under the Information tab you see a non scalable ugly icon. 

Again another petty thing, but something that I think should be "ironed" out by final release.
Comment 1 Peter Penz 2007-11-21 00:21:17 UTC
Thanks for the report. I fully agree that this does not look nice, but this is something which cannot fixed inside Dolphin but must be fixed within the icon set shipped with the distribution.
Comment 2 Ben Kevan 2007-11-21 00:30:44 UTC
Thank you Peter. I will open bug on bugzilla.novell.com 

Thank you. 
Comment 3 Ben Kevan 2007-11-27 17:30:17 UTC
it tries to load an 128x128 icon

 KIO::PreviewJob* job = KIO::filePreview(list,                                 
m_preview->width(), KIconLoader::SizeEnormous,

where SizeEnormous equals to 128 but the network icon only exists for

./16x16/actions/network.png
./22x22/actions/network.png
./32x32/actions/network.png
./48x48/actions/network.png

Which actually doesn't exist. I don't think it is a Distro bug but an upstream issue. 
Comment 4 Vladislav Blanton 2007-12-25 06:35:50 UTC
Actually, it seems that this is a bug for the oxygen icon set...
Comment 5 Jakob Petsovits 2008-01-04 03:30:40 UTC
The network icon is gone from KDE 4.0 completely (or should be), if I'm correct then Dolphin now uses network-workgroup (or should use ;) ...I don't remember that perfectly).

Please have a look if it still happens in the 4.0 release for the "Network" place. Might not be fixed, I heard of the desktop icon being blurred - even if that one ("user-desktop") comes in all sizes in the Oxygen icon theme.

No idea what's going on here, but I also haven't researched very deeply.
Comment 6 Jakob Petsovits 2008-01-07 03:41:24 UTC
Ok, so the error is not in Oxygen, it's in the file properties dialog or in some functionality that's used by it.

Steps to reproduce:
1. Create a directory.
2. Right click -> Properties, and select a new icon there.
3. Enter the directory (which now appears with the new icon) and open the hidden file ".directory" in there.
4. You can see that the assigned icon is not the size independent plain icon name but rather an absolute path to a specific PNG, for example like this: Icon=/home/jakob/dev/kde/install/kde/share/icons/oxygen/48x48/places/user-desktop.png

Changing this to "Icon=user-desktop" fixes the scalability issue, but it's a severe bug that this occurs at all. Please look into this bug as soon as feasible.

It's a bit unfortunate that this bug will be in 4.0 because it's actually stored as a user setting that cannot trivially be updated afterwards.
Comment 7 Peter Penz 2008-01-07 06:13:20 UTC
Thanks for the good analyzes, it's on my TODO list for 4.0.1!
Comment 8 Ben Kevan 2008-01-07 19:06:10 UTC
Peter I know 4.0.0 is in freeze so is there any way to make the patch to 4.0.1 change the Icon=user-desktop in the configuration files or will they point to a static icon until that config file is deleted / recreated or manually modified? 

That's a huge bummer that everyone that starts with KDE 4.0.0 will get stung by this for as long as they use it (by default at least)
Comment 9 Peter Penz 2008-01-07 19:43:11 UTC
> Peter I know 4.0.0 is in freeze so is there any way to make
> the patch to 4.0.1 change the Icon=user-desktop in the
> configuration files or will they point to a static icon
> until that config file is deleted / recreated or manually modified?

I'm not sure yet. The code is outside the Dolphin scope (corresponding to the analyzes above probably in KPropertiesDialog) and I must have a look on the code first...  
Comment 10 Peter Penz 2008-01-16 20:51:10 UTC
I've fixed this issue for KDE 4.0.1 and KDE 4.1. For users that already have configured their custom icon with KDE 4.0.0 there is no other way than to select the icon again or delete the .directory file :-(