Bug 152481 - Subtle API change in date parsing breaks some cookie expiration cases and ???
Summary: Subtle API change in date parsing breaks some cookie expiration cases and ???
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: general (show other bugs)
Version: 4.0
Platform: unspecified Linux
: NOR major
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
: 152861 152957 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-11-17 19:40 UTC by sts
Modified: 2009-01-04 15:15 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description sts 2007-11-17 19:40:45 UTC 
Version:           3.95.2 (KDE 4.0 Beta4) (using KDE 3.95.2 (KDE 4.0 Beta4), compiled sources)
Compiler:          gcc
OS:                Linux (i686) release 2.6.22.12-0.1-default

If I click on Help and "Probleme oder Wünsche melden" (report problems or wishes) and I use the assistent.. button, I can't login to bugs.kde.org! I have cookies enabled. It works If I open bugs.kde.org with another konqueror window. I think the way to login is different.
Comment 1 Maksim Orlovich 2007-11-22 20:22:37 UTC 
We're somehow losing cookies set on redirected chunked message -again-.
Allan, any chance you could take a look?
Comment 2 Maksim Orlovich 2007-11-22 21:02:21 UTC 
Actually, it's probably in the cookie jar and not kio-http this time, I think.
Comment 3 Maksim Orlovich 2007-11-22 21:45:28 UTC 
Yikes. The reason for this problem is that when parsing fails using KDateTime and one calls to toTime_t it returns -1. The old KRFCDate returned 0.
This case is easy to fix, but there are dozens of other instances of the same thing.
Comment 4 Maksim Orlovich 2007-11-25 18:14:53 UTC 
*** Bug 152861 has been marked as a duplicate of this bug. ***
Comment 5 Tommi Tervo 2007-11-27 08:30:56 UTC 
*** Bug 152957 has been marked as a duplicate of this bug. ***
Comment 6 Maksim Orlovich 2007-11-27 20:08:10 UTC 
SVN commit 742290 by orlovich:

Adjust this to an API incompatibility between KRFCDate and KDateTime. This fixes 
parsing cookies on many websites (such as the bugs.kde.org's wizard's login!).
Still, many other spots need similar adjustment

CCBUG:152481


 M  +5 -2      kcookiejar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=742290
Comment 7 sts 2009-01-04 15:15:36 UTC 
works for me..