Bug 152243 - Card Deck Selection Dialog only shows SVG card decks
Summary: Card Deck Selection Dialog only shows SVG card decks
Status: RESOLVED FIXED
Alias: None
Product: libkdegames
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Andreas Beckermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-13 11:03 UTC by stranzenbach
Modified: 2008-08-17 01:24 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screen Shot showing that the KDE3 cards do work (72.50 KB, image/png)
2007-12-20 19:14 UTC, James Richard Tyrer
Details
KPat config dialog showing card selection with grey (68.13 KB, image/png)
2007-12-22 12:17 UTC, jos poortvliet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description stranzenbach 2007-11-13 11:03:56 UTC
Version:           2.2.2b (using KDE 3.93.00 (KDE 4.0 Beta2), compiled sources)
Compiler:          gcc
OS:                Linux (i686) release 2.6.22.12-0.1-default

The color layout of the cards is extremly bad. It is dark red or black. Playing ist almost not possibile. How can i change to the color lay out of the cards?

I report this as a bug, because the game is very badly playable.
Best regards
Edmund Stranzenbach
Comment 1 Aaron J. Seigo 2007-11-13 22:11:27 UTC
i have to agree; the white oxygen cards are much easier to determine what they are and they still look nice and striking.
Comment 2 James Richard Tyrer 2007-11-15 09:28:13 UTC
I presume that we are talking about the playing cards in card games.

Yes, I think that all of the KDE4 card faces are too artsy.  The simple solution to this is to include the traditional styles: "Standard" & "Bonded" in the selections.

I happened to click the "Settings -> Random Cards" you can select one of the more traditional card faces which you can't seem to select with "Settings -> Select Deck".  This is strange.

I also miss my green background.
Comment 3 stranzenbach 2007-11-16 10:38:45 UTC
Thanks for your answer.
I've magaged to install the original gane of kde3, which is ok.
Best regards
Eddy
Comment 4 James Richard Tyrer 2007-12-19 03:03:14 UTC
Having looked into this, I am revising the bug.

IMHO, the problem isn't that there are various overly artsy card decks which I personally don't like.  The problem is that I can't easily select the standard "Bonded" style US size cards (IIUC, US cards are fatter rectangles than European ones).

I find that the Card Deck Selection dialog only shows the SVG card decks for selection although the PNG decks which include the standard US style decks are installed and can be selected with the "Random Cards" function.

So, I don't see this as an artist issue since the problem is that you can't use the dialog to select the PNG card decks.  So, this is a code issue with KPat.
Comment 5 Stephan Kulow 2007-12-19 10:03:01 UTC
SVN commit 750440 by coolo:

everyone (beside jrt) agrees that white cards are
better 
CCBUG: 152243


 M  +2 -2      cardmaps.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=750440
Comment 6 James Richard Tyrer 2007-12-19 20:35:48 UTC
This isn't about the color of the cards, it is about their design.

I did not file the original bug report.
Comment 7 James Richard Tyrer 2007-12-20 19:14:31 UTC
Created attachment 22636 [details]
Screen Shot showing that the KDE3 cards do work

There seems to be some confusion about this bug.

Not liking the default is not a bug.  If that is actually the issue, then the
bug should be closed as invalid or changed to a wishlist item.

HOWEVER, not being able to select a carddeck which you like -- specifically not
being able to select the cards which you used in KDE3 *is* a bug.

The KDE3 cards do work in the KDE4 version.  However, it is not possible to
select them with the Carddeck Selection dialog.
Comment 8 jos poortvliet 2007-12-22 12:17:54 UTC
Created attachment 22649 [details]
KPat config dialog showing card selection with grey

From what I can see, JRT is right - the KDE3 cards still work, but can't be
chosen. I don't really understand why the 'fixed size' thing is greyed out, I
was unable to get it to work.

Using 'F9' (random cards) repeatedly with a maximized window will show the
fixed-size and SVG cards pass you by... But you can only choose SVG cards in
the IU.

I see three solutions:
Let's ignore this (meh...)
Disable the old artwork (some won't be happy ;-))
Allow choosing fixed size artwork. I guess this one would be the best, and it
seems the work on that is *almost* done, as there is already an option to allow
choosing fixed-size artwork.

Imho there shouldn't be a separate option, btw, just let fixed size artwork be
there too. The scalable ones are already called SVG, make that Scalable and add
'fixed' to the old artwork. Maybe also remove the 'lock backside to frontside',
I don't see why it's that important and the options just clutter the interface.


This isn't meant to bash KPat, it rocks and is one of those apps you can use
for showing off KDE 4 during presentations ;-)
(and I like the SVG artwork so I would not be unhappy with removing the old
artwork...)
Comment 9 James Richard Tyrer 2008-02-21 04:20:10 UTC
I note that this appears to _currently_ work in TRUNK, which is no guarantee that it will work in the next release BRANCH. 

It still doesn't work in the 4.0 BRANCH.

Comment 10 Kevin Kofler 2008-02-22 04:08:10 UTC
JRT: Are you _sure_ this is fixed in the trunk? I can't find the relevant commit. If you're referring to coolo's commit from comment #5, that one just changes the default theme from Oxygen to Oxygen-white, that's definitely not critical to backport.
Comment 11 James Richard Tyrer 2008-02-22 06:25:26 UTC
I don't know if it was deliberately fixed or not.  Sometimes problems just mysteriously go away.  If that is the case, it should be closely watched till the release of 4.1.0.

But, yes! it does work.  I can select the PNG card decks.  I have tried "Standard" and "Konqi", and they work.  There is a slight issue with the background when using the PNG decks.

OTOH, for some reason the there is a problem with the GNOME "Bonded" deck.  It loads fine but the cards have the wrong aspect ratio -- they are too short.

Comment 12 Richard Hartmann 2008-08-17 01:14:27 UTC
I think this can be closed, no? I can select PNG decks in KPat in 4.1
Comment 13 James Richard Tyrer 2008-08-17 01:24:08 UTC
Yes, this works in the 4.1 release.