Bug 152182 - JJ: checkbox on "show regulator" menu entry shows wrong value
Summary: JJ: checkbox on "show regulator" menu entry shows wrong value
Status: RESOLVED WORKSFORME
Alias: None
Product: kmplot
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Klaus-Dieter M
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-11 23:10 UTC by Stefan Majewsky
Modified: 2014-12-17 18:06 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Bug fix (462 bytes, patch)
2010-02-01 16:44 UTC, Vitor Boschi da Silva 		Details
Bug Fix (1.19 KB, patch)
2012-02-06 15:04 UTC, Rahul Sharma 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Majewsky 2007-11-11 23:10:37 UTC 
Version:           1.2.0 (using KDE KDE 3.95.0)
Installed from:    SuSE RPMs
OS:                Linux

In the "View" menu in KmPlot, there is an option that reads "show regulators" or such (may differ from the real value because I don't know the English translation). If you cannot find it: it's the last point in this menu. It has a checkbox to indicate whether the regulators are shown or not.

On my SuSE 10.3 with KDE 3.95.2, the checkbox shows the wrong value: It is checked when the regulators are hidden, and unchecked when they appear on the screen. This seems to be a missing "not" somewhere in a condition or initialisation value, therefore I marked it as a Junior Job.
Comment 1 Stefan Majewsky 2007-11-30 22:25:00 UTC 
I cannot reproduce after updating to a current version. Seems like someone fixed it.
Comment 2 Eckhart Wörner 2008-12-29 18:04:39 UTC 
Bug can be reproduced by creating a new plot and activating slider for the parameter. "Show sliders" then gets checked without the sliders being shown.
Comment 3 Vitor Boschi da Silva 2010-02-01 16:44:12 UTC 
Created attachment 40438 [details]
Bug fix

I think this patch solves the bug, by opening the sliders window when the user selects the checkbox.
Another way this could be fixed, is by not opening the window, nor checking the menu entry.
Comment 4 Burkhard Lück 2011-07-12 06:57:50 UTC 
@ Victor:
Applied your patch in master, but it does not works as expected:

Select View->Show Sliders, Slider Window is opened, click Close button, Show Sliders option in the menu is still activated.

Repeat these steps a second time (Select View->Show Sliders, Slider Window is opened, click Close button) the option Show Sliders is deactivated.
Comment 5 Rahul Sharma 2012-02-06 15:04:18 UTC 
Created attachment 68559 [details]
Bug Fix

I hope this fixes the bug.
Comment 6 Burkhard Lück 2012-02-07 09:27:48 UTC 
(In reply to comment #5)
> Created an attachment (id=68559) [details]
> Bug Fix
> 
> I hope this fixes the bug.

Applied your patch + also the missing *.h file.
Bug is fixed for me now
Comment 7 Rahul Sharma 2012-02-13 11:46:07 UTC 
If this bug is fixed, then somebody mark this bug fixed please.
Comment 8 Burkhard Lück 2012-02-16 21:16:54 UTC 
(In reply to comment #7)
> If this bug is fixed, then somebody mark this bug fixed please.

Afaik the bug is not fixed.

Please put your patch in https://git.reviewboard.kde.org/ against the kdeedu project
Comment 9 Christoph Feck 2014-12-17 18:06:51 UTC 
Works with the frameworks branch, which will be merged to master for 15.04 release.