Bug 151849 - Add Right-MouseButton-menu entry to exit fullscreen [patch]
Summary: Add Right-MouseButton-menu entry to exit fullscreen [patch]
Status: RESOLVED WORKSFORME
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Menus (show other bugs)
Version: 0.9.2
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-04 16:25 UTC by Martin Bernreuther
Modified: 2017-08-02 21:08 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.6.0


Attachments
provide a right-mouse button popup entry to leave fullscreen mode (3.87 KB, patch)
2007-11-17 17:02 UTC, Arnd Baecker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Bernreuther 2007-11-04 16:25:30 UTC
Version:           0.9.2-final (using KDE KDE 3.5.7)
Installed from:    SuSE RPMs
OS:                Linux

If a digikam user changes to fullscreen mode using e.g. View/Fullscreen or the task bar button,
there's no obvious way to change back! How do you know about Ctrl-Shift-F, if this
was not used to change to fullscreen? There's no hint and the user might just end up
changing to a console and to kill digikam...

There should be an entry in the "Right mousebutton menu" for "toggle fullscreen",
but with my OpenSUSE 10.3 version in the RMB menu of the album view there's only a
greyed-out Insert and in the single photo view, there's only a "back to album"
(But you're still in full screen mode then) and this is also the behaviour pressing
the "ESC"ape button. Trying out the "F"unction-keys is maybe a natural behaviour, which
won't give the user much success, but Ctrl-Shift-F ???
In digikam AFAIK, there's no menu popping up, if you go with the mouse to the
upper or lower border like in gwenview or the KDE control bar, which can be configured
to hide automatically. This would also be a place to look for a "toggle fullscreen" entry.

This is no real bug, but a real annoyance to a newcomer.
(And it shouldn't be too hard to do something against it, since RMB-menus are already there.)
Comment 1 Mikolaj Machowski 2007-11-13 00:17:27 UTC
I would make this entry INVALID. Not that this is invalid per se but
this is KDE way of doing this and should be solved on completely
different level.
Comment 2 Arnd Baecker 2007-11-13 07:35:12 UTC
Mikolaj, so what do you suggest as alternative solution ?
(adding a RMB-menu would be easy and a quick solution ... ;-)

Best, Arnd
Comment 3 caulier.gilles 2007-11-13 07:41:59 UTC
Arnd,

There is an old patch from me to add RMB pop-up menu on native digiKam SlideShow tool... but it still bugos (crash in some case). It need to be hacked a little before to be applied on svn. Because i'm very busy with KDE4 port i have delayed finalization of this patch...

File is here : http://digikam3rdparty.free.fr/misc.tarballs/slideshow.patch

If you try to apply it against svn, you will certainly seen few problems. It very old (2007/03/18 - digiKam 0.9.1).

If you want to play with it, fell free (:=)))...

Gilles



Comment 4 Mikolaj Machowski 2007-11-13 11:35:51 UTC
Yes, Arnd. For quick solution adding top(?) entry in RMB menu is the
best.
Comment 5 Arnd Baecker 2007-11-16 15:10:37 UTC
Martin, just to be sure: if you don't hide the tool-bar, then there
is no problem, because the button to bring you back to non-full-screen
mode is still there, right?
Comment 6 Martin Bernreuther 2007-11-17 10:18:15 UTC
No! The toolbar and statusbar are enabled and will be shown first,
but after switching to fullscreen mode both disappear. I also tried
to move the mouse pointer to the very top or bottom, but no toolbar
will show up.

And sorry, it was wrong to put the "add RMB menu" in the subject,
because there are certainly many other "solutions". I didn't know
about the problems and thought this would be the easiest and quickest
way to do something about it...
Comment 7 Arnd Baecker 2007-11-17 12:00:38 UTC
Just that I understand things completely:
Presumably you are using the configuration options:
- "Light Table settings": [x] Hide toolbar in fullscreen mode
- "Image editor"        : [x] Hide toolbar in fullscreen mode
Note sure how one can have an album view, switched to
full-screen mode, such that the toolbar is visible before going
to full-screen, but not in full-screen mode ...
Comment 8 Arnd Baecker 2007-11-17 17:02:25 UTC
Created attachment 22101 [details]
provide a right-mouse button popup entry to leave fullscreen mode

This is the intermediate status of the patch.

Issues:
a) this should only be active when in fullscreen mode
   (I.e., how to find out in albumiconview.cpp
    that one is in fullscreen mode? See the place marked by FIXME.)
b) Should we also add such an menu option if one is
   in preview mode in fullscreen mode?
c) The same type of additional RMB entry should be also
   done for the full-screen mode of the image-editor.

Gilles, after a decision on b) and c), 
and if the overall structure and approach of this patch is ok,
I will continue work on it.
Comment 9 Martin Bernreuther 2007-11-18 13:34:28 UTC
Regarding Comment #7:

Sorry again!
"Image editor"        : [x] Hide toolbar in fullscreen mode
was checked! (Regarding Comment #6, I was refering to the
menu entry "Settings", where there's a "hide toolbar" and
"hide statusbar" as first and second entry, and I wasn't
aware of the entries in the digikam configuration. I also
was not aware that "Image editor settings" are also valid
for the view mode)
Nevertheless, I still think that a "toggle fullscreen"
functionality should be intuitively found by a user even
if the toolbar is hidden (which was the default here).

About Comment #8 issue a:
"Toggle fullscreen mode" (Ctrl-Shift-F) makes also sense in
non-fullscreen mode. But in non-fullscreen mode it's certainly
not that important and if you want the RMB menu not to be too crowded,
the suggested behaviour is presumably the better solution.
issue b+c:
I think there should be always an easy way back from fullscreen mode.
If there's a "KDE way of doing this" (Comment #1): great, but the
user should be aware of such a way and therefore it should be intuitive/
easy to find.

@Arnd Baecker: THANK YOU FOR THE PATCH!
Comment 10 Andi Clemens 2009-01-03 22:30:57 UTC
Is this one still valid? 

Andi
Comment 11 caulier.gilles 2009-06-19 08:06:47 UTC
*** Bug 196920 has been marked as a duplicate of this bug. ***
Comment 12 Andi Clemens 2009-10-21 14:14:05 UTC
Well it is not difficult to add an action in the context menu, and I think we should do it. How should an unexperienced user ever get out of fullscreen if he doesn't know the default keyboard shortcut, especially when the toolbar is hidden?

Gwenview also handles it this way.

We could hide this action when not in fullscreen mode, but display it when we are fullscreen. This should be easy with the ContextMenuHelper.

Another problem: The option for hiding the toolbar in fullscreen mode is located in the image editor tab, but actually it applies to AlbumUI as well.

I would move this setting into the general (misc) tab instead.
Comment 13 Andi Clemens 2009-10-21 14:16:25 UTC
Or duplicate the settings option into "Album View" as well and handle them separately.
Comment 14 DGardner 2009-12-09 21:40:38 UTC
My wishlist item in bug #192424 is another way to handle this.
You could add the RMB menu option, but also have an "autohide"
option for the tool-bar that makes it appear when the mouse
pointer is moved to the edge of the screen.
Comment 15 caulier.gilles 2011-12-13 09:00:33 UTC
This patch need to be adapted to git/master.

Also, it do not handle all digiKam views which can be switched to full screen mode. It must be extended...

Gilles Caulier
Comment 16 caulier.gilles 2011-12-16 11:39:30 UTC
Arnd,

Do you see my comment #15 ?

Gilles Caulier
Comment 17 Andi Clemens 2012-04-06 17:35:29 UTC
The fullscreen action is already added to the context menu, therefore I'll close this one as WORKSFORME