Bug 151844 - [patch] Build crashes if OpenEXR and IlmBase are installed in different prefixes
Summary: [patch] Build crashes if OpenEXR and IlmBase are installed in different prefixes
Status: RESOLVED INTENTIONAL
Alias: None
Product: buildsystem
Classification: Developer tools
Component: KDE4 (cmake) (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Alexander Neundorf
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-04 13:17 UTC by Yury G. Kudryashov
Modified: 2012-05-22 12:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
My version of FindOpenEXR.cmake (2.12 KB, patch)
2007-11-04 13:21 UTC, Yury G. Kudryashov 		Details
My version of FindIlmBase.cmake (2.32 KB, patch)
2007-11-04 13:21 UTC, Yury G. Kudryashov 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Yury G. Kudryashov 2007-11-04 13:17:55 UTC 
Version:            (using KDE KDE 3.95.0)
Installed from:    Compiled From Sources
Compiler:           It's cmake-files related, not compiler-related
OS:                Linux

FindOpenEXR.cmake looks for IlmBase components in the OpenEXR include/lib directories. So if prefixes of OpenEXR and IlmBase are different, build fails.
Comment 1 Yury G. Kudryashov 2007-11-04 13:21:09 UTC 
Created attachment 21998 [details]
My version of FindOpenEXR.cmake

I've splitted FindOpenEXR.cmake into two files: FindOpenEXR.cmake and
FindIlmBase.cmake.
Comment 2 Yury G. Kudryashov 2007-11-04 13:21:51 UTC 
Created attachment 21999 [details]
My version of FindIlmBase.cmake
Comment 3 Yury G. Kudryashov 2007-11-27 01:15:56 UTC 
Actually, build doesn't crash but KDE is failed to find OpenEXR.
Comment 4 Yury G. Kudryashov 2008-01-14 19:29:45 UTC 
Hi!
Could you have a look at bug #151844? It is marked as UNCOMFIRMED for
more than two months and it is assigned to you for about a month...
If you have no time at the moment to check my version of
FindOpenEXR.cmake, could you write to me about it? I just want to know
that my bug/patch report is not lost forever...
Thanks for great product! And excuse me for my English...
Comment 5 Haris Kouzinopoulos 2008-01-22 08:27:04 UTC 
Maybe you should add your attachments as "patch" so the bug can be shown on the "show bugs with patches" b.k.o query?
Comment 6 Raphael Kubo da Costa 2009-08-25 03:55:46 UTC 
Hi there. Can you confirm if the issue is still valid?
Comment 7 Yury G. Kudryashov 2009-08-28 13:19:18 UTC 
Yes, I can. Steps to reproduce on any distro:
1. Install OpenEXR (not ilmbase) into non-standard prefix (say, /tmp/prefix).
2. `export PKG_CONFIG_PATH=/tmp/prefix/lib/pkgconfig`
3. Try to configure kdelibs.
Comment 8 Raphael Kubo da Costa 2009-08-29 17:59:22 UTC 
I've taken a look at both patches. At first glance, you should lowercase your commands. Please look at KDE's CMake Coding Style guide at http://techbase.kde.org/Policies/CMake_Coding_Style

Furthermore, whenever a new CMake file is to be added (such as your FindIlmBase.cmake) to kdelibs, it first needs to be reviewed by the buildsystem team.

So in order to have this bug fixed and your patches applied, you should adapt them to the code conventions used for CMake files and then send them to the kde-buildsystem mailing list (see http://www.kde.org/mailinglists for instructions on how to subscribe to it). Alexander Neundorf, who's our CMake guru, will be offline for a few more days, but after that I think he can review your patches.

Thanks!
Comment 9 Yury G. Kudryashov 2012-05-22 12:34:30 UTC 
It doesn't make sense to change it in kdelibs now. I'll submit this to extra-cmake-modules.