Version: (using KDE KDE 3.5.8) Installed from: SuSE RPMs This is scary -- the default button is [delete]. It is too easy to loose all data from KMail.
Created attachment 21980 [details] Proprosed patch I have this patch ready in my SVN checkout. If it is OK I will commit it.
Jure, Yes, you can commit. If you can fix in both the 3.5 branch and trunk that would be great. Thanks!
Does the patch actually compile? I am asking because it has to commas side by side, which looks wrong to me. So, please test if it compiles and works correctly, then apply it to the 3.5 branch. I'll be doing the patch for trunk. In trunk, KMessagebox actually does not respect the Dangerous flag, so I'll fix that as well.
SVN commit 732011 by tmcguire: Deleting a folder is a potentially dangerous operation, so set the 'dangerous' flag when showing the warning messagebox. Based on a patch by Jure Repinc. CCBUG:151715 M +5 -3 kmmainwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=732011
Hm it looks like that in KDE 3.5 Dangerous flag also is not respected. I've just got home and compiled with the patch but Delete still remained the default selected button.
> Hm it looks like that in KDE 3.5 Dangerous flag also is not respected. Yes, seems like it is broken there as well, see http://websvn.kde.org/branches/KDE/3.5/kdelibs/kdeui/kmessagebox.cpp?revision=523229&view=markup (and search for 'dangerous', it is only mentioned once there) My patch for this issue in trunk is rev. 732020 BTW. I'll close this bug as FIXED now, as it is fixed in trunk. Not sure what to do about 3.5, but I personally don't worry too much about that.
SVN commit 732630 by tilladam: Merged revisions 731502-732628 via svnmerge from svn+ssh://tilladam@svn.kde.org/home/kde/trunk/KDE/kdepim ................ r731539 | mikearthur | 2007-11-01 00:32:50 +0100 (Thu, 01 Nov 2007) | 2 lines Add alignment and strikethrough options to WYSIWYG editor. ................ r731611 | scripty | 2007-11-01 08:40:38 +0100 (Thu, 01 Nov 2007) | 1 line SVN_SILENT made messages (.desktop file) ................ r731692 | tmcguire | 2007-11-01 16:49:46 +0100 (Thu, 01 Nov 2007) | 3 lines tabs-- (one of the tabs actually was inside a string, causing a minor bug) ................ r731725 | tilladam | 2007-11-01 19:13:34 +0100 (Thu, 01 Nov 2007) | 2 lines Re-add the nepomuk feeder. ................ r731772 | mlaurent | 2007-11-01 21:19:33 +0100 (Thu, 01 Nov 2007) | 2 lines Two differents separator ? ................ r731883 | scripty | 2007-11-02 08:38:30 +0100 (Fri, 02 Nov 2007) | 1 line SVN_SILENT made messages (.desktop file) ................ r731894 | mlaurent | 2007-11-02 09:10:11 +0100 (Fri, 02 Nov 2007) | 2 lines Fix icons ................ r732011 | tmcguire | 2007-11-02 15:40:00 +0100 (Fri, 02 Nov 2007) | 8 lines Deleting a folder is a potentially dangerous operation, so set the 'dangerous' flag when showing the warning messagebox. Based on a patch by Jure Repinc. CCBUG:151715 ................ r732122 | djarvie | 2007-11-02 22:01:32 +0100 (Fri, 02 Nov 2007) | 1 line Style ................ r732144 | djarvie | 2007-11-02 23:32:17 +0100 (Fri, 02 Nov 2007) | 5 lines Fix failure to trigger some date-only alarms (e.g. after system hibernation). Fix date-only alarms triggering every minute until start-of-day time (bug 146952). Forward port of commit 732115. ................ r732193 | winterz | 2007-11-03 03:38:33 +0100 (Sat, 03 Nov 2007) | 2 lines reduce the debug noise ................ r732197 | winterz | 2007-11-03 04:07:01 +0100 (Sat, 03 Nov 2007) | 7 lines - Port from KLibFactory to KPluginFactory - Make all the plugins have the same naming convention of "libfoo_korganizer", even though we (as in KDE) will probably decide to remove the "lib" prefix. - Make the yearprint plugin work - various minor clean-ups ................ r732217 | scripty | 2007-11-03 08:50:29 +0100 (Sat, 03 Nov 2007) | 1 line SVN_SILENT made messages (.desktop file) ................ r732235 | reitelbach | 2007-11-03 10:39:45 +0100 (Sat, 03 Nov 2007) | 4 lines typos SVN_SILENT ................ r732251 | vkrause | 2007-11-03 11:26:31 +0100 (Sat, 03 Nov 2007) | 49 lines Merged revisions 724820-725839,725842-726385,726387-726917,726919-726931,726933-728589,728591-728594,728596-728621,728623-729262,729264-730751,730753-731066,731068-731441,731443-731704 via svnmerge from https://vkrause@svn.kde.org/home/kde/branches/work/arzie_akonadi ........ r724820 | arzie | 2007-10-13 16:58:06 +0200 (Sat, 13 Oct 2007) | 1 line Provide some error handling. ........ r724821 | arzie | 2007-10-13 16:58:53 +0200 (Sat, 13 Oct 2007) | 1 line Add extra debug info. ........ r725902 | arzie | 2007-10-16 16:14:27 +0200 (Tue, 16 Oct 2007) | 1 line Prevent some unnecessary change notifications. ........ r725910 | arzie | 2007-10-16 16:56:23 +0200 (Tue, 16 Oct 2007) | 1 line Removed SearchProviders and added feeder agents. ........ r726785 | arzie | 2007-10-18 23:42:07 +0200 (Thu, 18 Oct 2007) | 1 line Allow bigger parts (LONGBLOB instead of BLOB as SQL data type). ........ r729262 | arzie | 2007-10-25 14:53:51 +0200 (Thu, 25 Oct 2007) | 1 line Small spelling fix. ........ r730783 | arzie | 2007-10-29 16:59:00 +0100 (Mon, 29 Oct 2007) | 1 line Add documentation. ........ r731444 | arzie | 2007-10-31 19:19:21 +0100 (Wed, 31 Oct 2007) | 1 line typo's ........ r731672 | arzie | 2007-11-01 15:21:18 +0100 (Thu, 01 Nov 2007) | 1 line typo's ........ r731702 | arzie | 2007-11-01 17:28:38 +0100 (Thu, 01 Nov 2007) | 1 line Support more than 1 index per table. ........ r731704 | arzie | 2007-11-01 17:29:08 +0100 (Thu, 01 Nov 2007) | 1 line Remove duplicate code. ........ ................ r732254 | vkrause | 2007-11-03 11:36:23 +0100 (Sat, 03 Nov 2007) | 2 lines Warn if the resource doesn't deliver the requested item part. ................ r732264 | vkrause | 2007-11-03 12:05:55 +0100 (Sat, 03 Nov 2007) | 2 lines Yet another unused field in the database. ................ r732267 | vkrause | 2007-11-03 12:17:14 +0100 (Sat, 03 Nov 2007) | 2 lines remove dead code ................ r732293 | mikearthur | 2007-11-03 13:23:26 +0100 (Sat, 03 Nov 2007) | 2 lines Add lists to WYSIWYG editor and "intelligent" rich text selector button. ................ r732313 | winterz | 2007-11-03 14:25:28 +0100 (Sat, 03 Nov 2007) | 3 lines Eliminate the "QLayout: Attempting to add QLayout "" to MonthViewCell "", which already has a layout" warnings. Thanks Pino! ................ r732340 | winterz | 2007-11-03 16:02:28 +0100 (Sat, 03 Nov 2007) | 2 lines fixup some icons and titles ................ r732341 | winterz | 2007-11-03 16:03:02 +0100 (Sat, 03 Nov 2007) | 2 lines minor change to the "enable tooltips.." configuration option text. ................ r732378 | winterz | 2007-11-03 18:25:40 +0100 (Sat, 03 Nov 2007) | 2 lines cleanup some superfluous kDebugs, or move them into the correct debugarea. ................ r732391 | pino | 2007-11-03 19:04:00 +0100 (Sat, 03 Nov 2007) | 3 lines icon renamings: - history-clear -> edit-clear-history ................ r732394 | tmcguire | 2007-11-03 19:08:26 +0100 (Sat, 03 Nov 2007) | 5 lines Fix homepage URL. SVN_SILENT ................ r732417 | tmcguire | 2007-11-03 20:38:19 +0100 (Sat, 03 Nov 2007) | 7 lines Some search fixes and some style fixes. Now the editor doesn't get into an infinite loop anymore when the search text is not found. Also, backward search and search from cursor works properly now. ................ r732418 | tmcguire | 2007-11-03 20:46:47 +0100 (Sat, 03 Nov 2007) | 3 lines Fix icon ................ r732425 | tmcguire | 2007-11-03 21:32:38 +0100 (Sat, 03 Nov 2007) | 4 lines - fix icons - deprecated-- ................ r732434 | winterz | 2007-11-03 21:58:47 +0100 (Sat, 03 Nov 2007) | 5 lines forward port SVN commit 732431 by winterz: port yet-another IMAP bugfix from the enterprise branch. also remove an assert() that can never be tripped. ................ r732447 | tmcguire | 2007-11-03 22:35:41 +0100 (Sat, 03 Nov 2007) | 3 lines Use the new icon for multiple drag items the Oxygen team has just commited. ................ r732464 | tmcguire | 2007-11-03 23:50:00 +0100 (Sat, 03 Nov 2007) | 4 lines Remove unnecessary #ifdef, it reportedly compiles fine on Windows. SVN_SILENT ................ r732614 | scripty | 2007-11-04 09:40:43 +0100 (Sun, 04 Nov 2007) | 1 line SVN_SILENT made messages (.desktop file) ................ _M . (directory) _M akonadi (directory) M +1502 -1742 akonadi/doc/pics/concept.eps M akonadi/doc/pics/concept.png M +138 -68 akonadi/doc/pics/concept.sla M +2 -0 akonadi/libakonadi/item.h M +11 -1 akonadi/libakonadi/resourcebase.cpp M +1 -1 akonadi/libakonadi/tests/resourcetest.cpp M +18 -17 akonadi/resources/knut/knutresource.cpp M +1 -1 akonadi/resources/maildir/maildirresource.h M +1 -2 akonadi/server/src/handler/select.cpp M +17 -12 akonadi/server/src/handler/store.cpp M +1 -1 akonadi/server/src/handlerhelper.h M +0 -1 akonadi/server/src/storage/akonadidb.xml M +1 -1 akonadi/server/src/storage/akonadidb.xsd M +9 -9 akonadi/server/src/storage/create-unittest-values.sql M +4 -21 akonadi/server/src/storage/datastore.cpp M +0 -1 akonadi/server/src/storage/datastore.h M +1 -1 akonadi/server/src/storage/dbinitializer.cpp M +1 -1 kaddressbook/thumbnailcreator/ldifvcardthumbnail.desktop M +3 -0 kalarm/alarmevent.cpp M +12 -1 kalarm/daemon.cpp M +1 -0 kalarm/daemon.h M +5 -14 kalarm/kalarmapp.cpp M +69 -46 kalarm/kalarmd/alarmdaemon.cpp M +3 -1 kalarm/kalarmd/alarmdaemon.h M +1 -1 kalarm/kalarmd/kalarmd.h M +5 -0 kalarm/kalarmd/org.kde.kalarm.kalarmd.Daemon.xml M +1 -1 kleopatra/kwatchgnupg/kwatchgnupgmainwin.cpp M +1 -1 kmail/kmcomposewin.cpp M +4 -0 kmail/kmfoldercachedimap.cpp M +4 -4 kmail/kmfoldertree.cpp M +1 -1 kmail/kmheaders.cpp M +6 -6 kmail/kmmainwidget.cpp M +1 -1 kmail/managesievescriptsdialog.cpp M +1 -1 kmail/managesievescriptsdialog_p.h M +2 -2 kmail/recipientspicker.cpp M +1 -1 kmail/searchwindow.cpp M +1 -1 knode/aboutdata.cpp M +1 -1 knode/knode_config_identity.desktop M +1 -2 korganizer/CMakeLists.txt M +4 -5 korganizer/interfaces/calendar/calendardecoration.h M +2 -2 korganizer/interfaces/calendar/plugin.h M +2 -2 korganizer/interfaces/korganizer/part.h M +1 -1 korganizer/interfaces/korganizer/printplugin.h M +43 -47 korganizer/koagendaitem.cpp M +13 -41 korganizer/koagendaview.cpp M +52 -52 korganizer/kocore.cpp M +6 -9 korganizer/kocore.h M +0 -6 korganizer/koeditorfreebusy.cpp M +89 -8 korganizer/koeditorgeneral.cpp M +16 -1 korganizer/koeditorgeneral.h M +5 -18 korganizer/koeditorgeneraljournal.cpp M +14 -18 korganizer/koeventeditor.cpp M +6 -7 korganizer/kojournaleditor.cpp M +6 -18 korganizer/komailclient.cpp M +2 -1 korganizer/komonthview.cpp M +2 -2 korganizer/koprefs.cpp M +6 -13 korganizer/koprefsdialog.cpp M +2 -2 korganizer/korganizer.kcfg M +1 -1 korganizer/korganizer_configcolorsandfonts.desktop M +1 -1 korganizer/korganizer_configdesignerfields.desktop M +1 -1 korganizer/korganizer_configfreebusy.desktop M +1 -1 korganizer/korganizer_configgroupautomation.desktop M +2 -2 korganizer/korganizer_configgroupscheduling.desktop M +2 -2 korganizer/korganizer_configmain.desktop M +1 -1 korganizer/korganizer_configplugins.desktop M +3 -106 korganizer/korganizer_configtime.desktop [TRAILING SPACE] M +2 -2 korganizer/korganizer_configviews.desktop M +13 -14 korganizer/kotimelineview.cpp M +9 -18 korganizer/kowhatsnextview.cpp M +0 -2 korganizer/multiagendaview.cpp M +6 -5 korganizer/plugins/datenums/datenums.cpp M +7 -6 korganizer/plugins/hebrew/hebrew.cpp M +5 -4 korganizer/plugins/picoftheday/picoftheday.cpp M +3 -2 korganizer/plugins/printing/journal/journalprint.cpp M +3 -1 korganizer/plugins/printing/year/yearprint.cpp M +1 -1 korganizer/plugins/printing/year/yearprint.desktop M +3 -2 korganizer/plugins/thisdayinhistory/thisdayinhistory.cpp M +10 -10 korganizer/theme.cpp M +1 -12 korganizer/themeimporter.cpp M +2 -2 kpilot/conduits/base/recordconduit.cc M +6 -2 kresources/scalix/kabc/scalix.desktop M +6 -1 kresources/scalix/kcal/scalix.desktop M +6 -0 kresources/scalix/knotes/scalix.desktop M +9 -10 libkdepim/kemailquotinghighter.cpp M +76 -83 libkdepim/kmeditor.cpp M +29 -27 libkdepim/kmeditor.h M +1 -27 libkdepim/kprefsdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=732630