Version: 0.1.5 svn (using KDE KDE 3.5.8) Installed from: Debian testing/unstable Packages I am running digikam and kipiplugins from svn (of a few days ago). When I try to batch convert from png to jpeg, I get the message in the subject as a popup window for each picture in the batch. In the terminal I get digikam: WARNING: Convert exit (0) The pictures seem to convert fine. I have Imagemagick 6.2.4 installed from debian unstable
I confirm the problem. Quick look at the code and perhaps there's a race condition in BatchProcessImagesDialog::startProcess(void), when the "if (!m_ProcessusProc->normalExit())" check is done immediately after starting the KProcess, while the documentation says that normalExit() returns true only if the process is already finished. But that's just a quick guess, I didn't study the code thoroughly.
Created attachment 22044 [details] Fixes bug #151578 I'm attaching a patch that solves the issue for me.
Created attachment 22047 [details] Fixes bug #151578 Adds an additional check to the previous patch
This patch fixes the problem for me. Could it maybe be committed for the 0.9.3 release?
David, I think you shouldn't mark the bug as resolved until it is fixed in svn. This way it won't get attention from the maintainers anymore.
Reopen according to Pawel's advice
SVN commit 738759 by cgilles: Do not test is KProcess is out imediatly. BUG: 151578 M +3 -3 Makefile.am M +207 -230 batchprocessimagesdialog.cpp M +3 -1 batchprocessimagesdialog.h M +71 -27 convertimagesdialog.cpp M +2 -0 convertimagesdialog.h M +0 -6 imagepreview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=738759
SVN commit 738848 by cgilles: missing to apply a part of Pawel patch here... CCBUGS: 151578 M +35 -3 batchprocessimagesdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=738848
Gilles, From kipi-plugins I only use batch conversion and that one is now working well. Hard to say about others, but I think the same should be done for "preview" KProcess additionally. For now it's still old way (immediate call to normalExit()). An irrelevant detail is that even if convert program is killed from outside and the user doesn't want to continue, the result message (added in processAborted()) says that it has been stopped by the user. Pawel
I still have this problem running digikam 0.9.3 and kipiplugins 0.1.5-rc1. It happens when klicking on the preview button for a filter. The filter works but this message box is annoying. Should this be already fixed in 0.9.3?
> Should this be already fixed in 0.9.3? Please remember that *digikam* is a project and *kipi-plugins* is another one. Batchprocess is a plugin belonging to kipi-plugins and it used by digikam. So they have different release time, even if they try to be near for major changes. Regards, Angelo
According to comment #10 bug reopen. Please to help us to find a solution take care to provide how to reproduce it. Here a way to: 1) Select one or more photos from album/directory - it depends on the host application 2) choose a batch process plugin that contains a preview button (color etc) 3) click on preview button, despite of the preview window is opened you'll get an error message that says: "Cannot run properly 'convert' program from 'ImageMagick' package" Angelo
Yes I am aware about the difference between both projects but I was uncertain who is responsible in this case... To reproduce this bug I simply select one photo and select the kipi plugin called in German "Bildfilterung" (perhaps: filter photo) and then select to sharpen the photo. If I click on the preview button (no matter if small or big one) I get the error message. As far as I can see, this happens with each filter plugin that has a preview if you simply click to show this preview. Thanks Rainer
SVN commit 757195 by cgilles: check if ImageMagick command line is exit normally when process is done, not just fater to startup it. BUG: 151578 M +8 -8 batchprocessimagesdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=757195