Bug 151345 - exporting CMYK in Absolute, undo, then Perceptual is different from exporting directly to Perceptual
Summary: exporting CMYK in Absolute, undo, then Perceptual is different from exporting...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-25 21:27 UTC by Eric Forgeot
Modified: 2007-11-30 22:36 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Forgeot 2007-10-25 21:27:55 UTC
Version:           1.6.3 (using KDE KDE 3.5.8)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Load a picture in RGB in Krita
Convert Image Type
Target color space to CMYK

Choose Absolute Colorimetric
Undo
Choose Perceptual instead => The rendering is still like in Absolute.

Close Krita, load the same image again

Choose Perceptual first => The rendering is much different from the one chosen the first time after the undo (also in Perceptual)

It's like once a conversion type is choosen (absolute, perceptual etc), it's locked to this choice and you can't change it even after an undo.
Comment 1 Cyrille Berger 2007-10-25 23:29:00 UTC
Uhm right, the caching of color conversion don't check if intent is different.
Comment 2 Cyrille Berger 2007-11-30 22:36:55 UTC
SVN commit 743410 by berger:

introduce a global cache for color conversion transformation (it's internal to KoColorSpace but shared between instance), it replaced the old code that was specific to one instance, and didn't work when a color space is destroyed. On a side note, the new cache take into account the rendering intent.

The bug fix can't easily be applied to the stable branch, so next stable release won't include, but it's going to be in next major release.
BUG:151345

 M  +1 -0      CMakeLists.txt  
 A             KoColorConversionCache.cpp   [License: LGPL (v2+)]
 A             KoColorConversionCache.h   [License: LGPL (v2+)]
 M  +2 -0      KoColorConversionSystem.h  
 M  +12 -0     KoColorConversionTransformation.cpp  
 M  +5 -0      KoColorConversionTransformation.h  
 M  +4 -40     KoColorSpace.cpp  
 M  +10 -0     KoColorSpaceRegistry.cpp  
 M  +6 -0      KoColorSpaceRegistry.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=743410