Bug 150296 - Images in LightTable are not compared in right order
Summary: Images in LightTable are not compared in right order
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: LightTable-Workflow (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-28 14:50 UTC by Fabien
Modified: 2022-02-01 09:18 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.9.3


Attachments
improved behaviour in navigate by pairs mode (4.45 KB, patch)
2007-10-09 16:56 UTC, Arnd Baecker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabien 2007-09-28 14:50:11 UTC
Version:           svn kde3 branch (using KDE KDE 3.5.4)
Installed from:    Ubuntu Packages
OS:                Linux

If you try to add image img01 and img02 into an empty lighttable, these images will be ordered correctly in the thumbbar, but img02 will appear on the left panel and img02 in the right panel.
I think it would make more sens to have the the contrary.


If you add 3 pictures img01 img02 img03 in an empty thumbbar, you will compare by default img02 and img03.
I guess here too, it would be better to compare first img01 and img02.


There's also another problem if you remove everything but last picture, or if you put only one picture. You see the same one on the left and right panel. I think it would be better to see it only in the left panel.

Finally, last issue :) : if you remove all items, you can still see the last picture in the panel. Maybe some code is missing the refresh the panel ?

BTW, with last fixes, this lighttable is nearly perfect: it was very useful for me to compare tens of moon pictures I took recently ;-)
Comment 1 Fabien 2007-09-28 14:51:25 UTC
Oops, I mean :

<<but img02 will appear on the left panel and img01 in the right panel>>

Sorry :)
Comment 2 Arnd Baecker 2007-09-28 15:07:33 UTC
Fabien, are you using the current svn version? 
If not, try that one please - I cannot reproduce any of the problems ... ;-)
Comment 3 caulier.gilles 2007-09-28 15:08:20 UTC
Same for me (:=)))

Gilles
Comment 4 Fabien 2007-09-28 15:16:58 UTC
Really ??
Yes, I'm using the latest svn version of kde3 branch...
Comment 5 Fabien 2007-09-28 15:24:52 UTC
Ok, I think I understood. I just removed the lighttable part of the digikamrc file to have standard behavior and the behavior is not the same.

Activate "Navigate by pair" and try again...
;-)
Comment 6 Arnd Baecker 2007-09-28 16:05:44 UTC
ouch!
<sarcasm>
I haven't got the slightest idea who proposed this navigate
by pair .... ;-)
(well, there is something coming to my mind, vaguely, ...)
</sarcasm>

To my shame I have to admit, that I haven't used it so far.
Obivously, you are the first to use this feature...
Do you think it is useful enough that I start looking
into what is going wrong here?
(it will be a mess to get the logic right...)
Comment 7 Fabien 2007-09-28 16:14:22 UTC
You’re Kidding, Right? ;-)

Seriously, "navigate by pair" is really a cool feature, I use it since the beginning...
Comment 8 Arnd Baecker 2007-10-09 16:56:27 UTC
Created attachment 21781 [details]
improved behaviour in navigate  by pairs mode

Hopefully most of the problems are cured by the attched patch, please
test thoroughly ...
One thing might count as bug or feature: if there is just one image,
it is shown both left and right. This allows to look at different places
of the same images (if the views are not synchronized).
I would suggest to leave this as is at the moment
(also in view of http://bugs.kde.org/show_bug.cgi?id=145533).
Comment 9 Mikolaj Machowski 2007-10-09 18:19:57 UTC
I would call that a feature :)
Comment 10 Fabien 2007-10-11 14:50:39 UTC
Ok, it looks fine. Thanks a lot Arnd !

Finally, I think it's ok abouth the same picture on both sides.
The only problem I see is that one could accidentally remove the picture by thinking "ok, the 2nd one is not better, let's remove it".
Comment 11 Fabien 2007-11-07 14:14:38 UTC
Any news about the patch ?

I used it for a few weeks with both "navigate by pair" active and inactive and it looks good for me...
I hope it can be applied before 0.9.3 final.
Comment 12 Arnd Baecker 2007-11-07 21:08:14 UTC
SVN commit 733997 by abaecker:

For the light table in the "Navigate by pair" mode images 
are now compared in the right order.

CCBUGS: 150296
TODO:KDE4PORT



 M  +2 -1      NEWS  
 M  +1 -2      digikam/albumiconview.cpp  
 M  +48 -15    utilities/lighttable/lighttablewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=733997
Comment 13 caulier.gilles 2007-11-08 09:56:32 UTC
SVN commit 734200 by cgilles:

digiKam from trunk (KDE4) : backport commit #733997 from KDE3 branch
BUG: 150296



 M  +2 -3      digikam/albumiconview.cpp  
 M  +45 -16    utilities/lighttable/lighttablewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=734200