Version: (using KDE KDE 3.5.6) Installed from: Unspecified Linux OS: Linux Wakeups are bad[1]. Each instance of kwrapper wakes up once a second, to see whether the application it started has quit yet. It checks the return value from kill(SIG_0). It can't use wait() because the application is started by kdeinit on kwrappers behalf, so kdeinit should be modified to do it and send "application died" messages to the appropriate kwrapper instances so they don't have to poll. In addition to helping bring down the number of wakeups on an idle system, kdeinit would be able to tell kwrapper what exit code the application terminated with. So if you start a program with kwrapper which terminates abnormally, it might be easier to find out the reason. [1] http://www.linuxpowertop.org/
Created attachment 21602 [details] KInit 3.5.6 - send LAUNCHER_DIED messages to kwrapper as well as klauncher
Created attachment 21603 [details] kwrapper 3.5.6 - wait for LAUNCHER_DIED messages instead of polling
Patches work for me, but I'm not a KDE developer - they could be in bad taste, break things I don't use, or be completely superceded by KDE 4. Released under the same license as the files they apply to.
Created attachment 21604 [details] KInit 3.5.6 - send LAUNCHER_DIED messages to kwrapper as well as klauncher Um, well heres the version of the Kinit patch that works for the _right_ reasons. (The previous one forgot to keep the socket alive to send the LAUNCHER_DIED message. I swear it actually worked; the only difference was kwrapper would always return 255).
The kwrapper patch is for KDE 3.5.7 (gentoo) broken. I get: wrapper.c: In function 'kwrapper_run': wrapper.c:287: error: 'pid' redeclared as different kind of symbol wrapper.c:283: error: previous definition of 'pid' was here wrapper.c:283: warning: unused parameter 'pid'
I would have responded earlier but my hard drive died. I get exactly the if I try to re-apply these patches. I'm afraid I must have attached a broken kwrapper patch. I've fixed the problem, built kwrapper and kdeinit, and I'm now using those binaries without any difficulties.
Created attachment 21674 [details] kwrapper 3.5.6 - wait for LAUNCHER_DIED messages instead of polling And heres the kwrapper patch that actually builds. Sorry!
No need for a sorry. Now it works. Thanks.
SVN commit 783850 by lunakl: Change kdeinit to tell kwrapper about the exit status in order to stop kwrapper from polling. Patch by Alan Jenkins <alan-jenkins@tuffmail.co.uk>. BUG: 149731 M +72 -25 kinit.cpp M +41 -25 wrapper.c WebSVN link: http://websvn.kde.org/?view=rev&revision=783850
Thanks for the patch, I somehow missed it before. I've applied the patch for KDE4.1. I'm a bit hesistant to commit to for 3.5 because of the changes in the launching code and this shouldn't make that big difference for 3.5 anyway, with Kicker having so many timers.
Thanks! My experience of Kicker is that it averages one wakeup a second - the same as kwrapper is without this patch. But I don't care enough about this issue in practise - I'm just happy it's been fixed in KDE4. I certainly appreciate the maintenance argument.