Bug 149555 - always present search box instead of search by right-clicking and selecting simple or advanced search
Summary: always present search box instead of search by right-clicking and selecting s...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Searches-Advanced (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-05 07:45 UTC by malte
Modified: 2019-12-28 06:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description malte 2007-09-05 07:45:59 UTC
Version:            (using KDE KDE 3.5.6)
Installed from:    Ubuntu Packages
OS:                Linux

I think the search interface would be much nicer if the search box was just always present (and advanced options could be accessible via a show/hide advanced options selection), instead of you having to right-click and select what kind of search you want to perform.
Comment 1 caulier.gilles 2007-09-05 08:03:58 UTC
It's a duplicate. Please check if a similar entry already exist in B.K.O before to create a new one.

Gilles Caulier

*** This bug has been marked as a duplicate of 133191 ***
Comment 2 Arnd Baecker 2007-09-05 08:12:18 UTC
Hi Gilles,

I don't think it is a duplicate!
Bug 133191 is about quick filtering for albums
(like we have it in the right-hand side "Comments/Tags" sidebar
and not about searches (though I would suggest such
a quick filter as well
This one is about improving the search interface.

Here are my comments/questions/suggestion to the original post:

What do you mean by "search interface" (the one obtained from 
"Quick Search" or the one obtained from "Advanced Search")
or the left-hand search side-bar?
What do you mean by "always displayed" (and where?)

One option is:
Get rid of the simple search and replace this in the left-panel by
a text entry (above the list of searches)
   Search: [ ....]   [SAVE SEARCH]
typing anything into that field will act like the "Quick search",
but the result displayed in the view in the middle.
The button [SAVE SEARCH] allows to save this search
(No distinguishment between advanced and simple search should be
made, i.e. all searches will come out as advanced searches internally
and editing the saved search will come up with the edit tool
for the advanced search).
Comment 3 malte 2007-09-05 17:53:58 UTC
Hi guys

Sorry, I could have been a little more descriptive. I don't think this is a dupe of the amarok-like search wish.

When you click on the 'searches' tab on the far left hand side, you get a blank window basically, if you don't have any saved searches. I found this perplexing the first time I saw it, and assumed that search function was not yet implemented all the way. But I soon realized you had to right click in the left pane to select simple or advanced search.

What I would suggest, would be to display the search box inside the right pane, in the same space that the search result images will be displayed, but above them. I would get rid of the right-click popup window altogether.

This would be more intuitive I believe, as it mimics how most search engines work, online or offline.

May I ask what search engine you use under the hood?
Comment 4 Arnd Baecker 2007-09-05 18:13:24 UTC
I am not sure whether it is technically possible to add
a search box in the middle view; Gilles what do you think?
Surely doable should be the approach in #2.

For searches queries to digikam's sql database are used.
Comment 5 malte 2007-09-05 18:27:52 UTC
I would recommend you consider using some ready made search engine, since sql lookups unfortunately can become a bit slow on large tables (when I'm done with my photo albums, it will have around 500k photos in thousands of albums! :). A favorite of mine is Xapian [http://www.xapian.org]

Perhaps I could submit a patch for this so you can test it, if I can find the time.
Comment 6 Arnd Baecker 2007-09-05 22:59:14 UTC
500k photos is a lot ;-) The number of images I have is an order of
magnitude smaller and I do not observe any delays from 
database lookups. Anyway, this would be a separate BKO.
(Also note that in the transition to KDE4 a lot in connection with
the database has/will be changed, so I would recommend to discuss digikam-devel before).

If you want to provide a patch for a search-box 
(integrating this in the side-bar seems simplest to me), this is very welcome!
Comment 7 malte 2007-09-06 19:57:29 UTC
I will take a look at it when time allows... Would love to contribute something.
Comment 8 caulier.gilles 2008-04-23 11:10:28 UTC
Malte,

Following recents progress into new Advanced Search tools from Marcel with KDE4 port, i close this file. 

Search tools have been rewritten. Screenshots are available at this url:

http://digikam3rdparty.free.fr/Screenshots/NewSearchTools

Gilles Caulier
Comment 9 caulier.gilles 2019-12-28 06:21:59 UTC
Not reproducible with 7.0.0-beta1