Bug 149479 - themes still active in khotnewstuff after deleting
Summary: themes still active in khotnewstuff after deleting
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: knewstuff (show other bugs)
Version: 3.5
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-02 16:12 UTC by meyerm
Modified: 2014-08-11 18:58 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to fix removing desktop plasma themes. (1.75 KB, patch)
2014-03-30 03:41 UTC, Andrei Amuraritei
Details

Note You need to log in before you can comment on or make changes to this bug.
Description meyerm 2007-09-02 16:12:27 UTC
Version:           0.12.5 (using KDE 3.5.7, Gentoo)
Compiler:          Target: i686-pc-linux-gnu
OS:                Linux (i686) release 2.6.22-gentoo

After downloading new smilies they are marked as installed in the "get new stuff"-dialog. But also after deleting them from within kopete they are still "active" in the dialog and can't be downloaded again.

After deleting the references to them from the kopete-config file and restarting kopete they are "new" again.
Comment 1 rockonthemoonfm 2012-08-14 09:25:51 UTC
this bug should be closed
Comment 2 rockonthemoonfm 2012-08-14 09:43:13 UTC
ok, the nice thing is that this bug is still correct regarding plasma themes in KDE SC 4.9 ...

waiting for a reply to help squashing this bug
Comment 3 Jeremy Whiting 2012-08-14 16:54:00 UTC
KNewStuff keeps a registry of what has been installed through it.  If you uninstall or delete stuff without using knewstuff to do it, it doesn't know about that.  KNewStuff doesn't go scan your hard drive to see if stuff that you have installed through it is still there, maybe it should.
Comment 4 rockonthemoonfm 2012-08-15 09:28:19 UTC
I've just deeply tested downloading/installing/using/removing something through knewstuff in kde 4.9 in Kubuntu Precise and it works for: amarok, colors, icons,

it is buggy for: 
- decorations: theme previews are not shown after installing/removing another theme is applied or the kcm module is reloaded. 
- plasma theme: doesn't REALLY uninstall themes, which are available even after uninstalling,
- cursors: pretty everything is buggy. 
1. if a HTML link is used for installing, even if operation is canceled, it looks as installed
2 installed themes (have they really been installed?)  not always are shown, sometimes 
3 if uninstalled from kcm shell, GHNS shell still displays it as installed.
- emoticons: here, again, if uninstalled from kcm shell, GHNS shell still displays it as installed.
- ksplash: here, again,  if uninstalled from kcm shell, GHNS shell still displays it as installed.
- KDM: themes are installed but not available. Not working. 

as you can see the actual state of art is terrible for a 4.9 release.
it's bizarre how different kcm modules has different problems with this library.
do not hesitate to reply for fixing all the bug.
I want to remark that the interfaces of all these kcm modules has really no homogeneous design style.. need desperately some love.

hope it has been useful
thanks for your attention
alex
Comment 5 rockonthemoonfm 2012-08-15 09:43:02 UTC
an update:

GHNS works well for wallpapers,
for plasmoids: if uninstalled from plasma shell, GHNS shell still displays it as installed.

alwys this problem present with uninstall buttons out of GHNS shell
Comment 6 Jay LaCroix 2013-04-30 03:02:43 UTC
This is still a problem in Kubuntu 13.04/KDE 4.10. I installed some Plasma themes through "Get Hot New Stuff" from within System Settings. I decided I didn't want the extra themes anymore, but even after uninstalling them, they are still listed as installed and available for use.
Comment 7 Jay LaCroix 2013-06-01 20:14:07 UTC
This bug was reported several years ago, and is still not fixed. Not being able to uninstall themes you've downloaded is a very embarrassing bug. I tested it again with 4.10.3. I downloaded "Helium" through the "Get Hot New Stuff dialog" and then I clicked the "uninstall" button. The theme is still there. I tried to reinstall it and remove it again, but the theme is now a permanent part of my KDE config with now way to remove it. I've tried it with other themes, and I have the same results.
Comment 8 Jeremy Whiting 2013-08-21 16:50:33 UTC
Git commit ab7b64e3a9c788814bda5c2dd2fce1a676c8e1ea by Jeremy Whiting.
Committed on 21/08/2013 at 16:46.
Pushed by whiting into branch 'master'.

Fix plasmapkg -t theme -r packagefilename to work when the package archive has been formatted correctly.
Note Helium on kde-look.org from the bug report is not formatted correctly, but has it's contents within a Helium folder.
REVIEW: 112128

M  +13   -1    plasma/tools/plasmapkg/main.cpp

http://commits.kde.org/kde-runtime/ab7b64e3a9c788814bda5c2dd2fce1a676c8e1ea
Comment 9 Jeremy Whiting 2013-08-21 16:51:56 UTC
Git commit 64505f15b9725d3d213990c5fce7f1fc2e41acc7 by Jeremy Whiting.
Committed on 21/08/2013 at 16:46.
Pushed by whiting into branch 'KDE/4.11'.

Fix plasmapkg -t theme -r packagefilename to work when the package archive has been formatted correctly.
Note Helium on kde-look.org from the bug report is not formatted correctly, but has it's contents within a Helium folder.
REVIEW: 112128

(cherry picked from commit ab7b64e3a9c788814bda5c2dd2fce1a676c8e1ea)

M  +13   -1    plasma/tools/plasmapkg/main.cpp

http://commits.kde.org/kde-runtime/64505f15b9725d3d213990c5fce7f1fc2e41acc7
Comment 10 Andrei Amuraritei 2014-03-30 03:41:30 UTC
Created attachment 85834 [details]
Patch to fix removing desktop plasma themes.

Attached patch to fix finding the metadata.desktop file in theme packages, so they can be removed from GHNS.
Comment 11 Andrei Amuraritei 2014-04-02 08:29:40 UTC
An updated version of the patch is found here, pending review. https://git.reviewboard.kde.org/r/117174/
Comment 12 Albert Astals Cid 2014-08-11 18:58:04 UTC
Git commit e82730bb44d30f98f294a52a4a43cf4ce03f720a by Albert Astals Cid, on behalf of Andrei Amuraritei.
Committed on 11/08/2014 at 18:56.
Pushed by aacid into branch 'KDE/4.14'.

Fix installing and removing desktop plasma theme packages.

Acked by Sebas

Sebas, please make sure you keep track of the reviews you +1 that are made by people without commit rights

CCMAIL: sebas@kde.org

REVIEW: 117174

M  +24   -1    plasma/packagestructure.cpp

http://commits.kde.org/kdelibs/e82730bb44d30f98f294a52a4a43cf4ce03f720a