Bug 149360 - Not all menu items may be bound to keyboard shortcuts.
Summary: Not all menu items may be bound to keyboard shortcuts.
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Keyboard (show other bugs)
Version: 0.9.2
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-29 23:04 UTC by Alain Knaff
Modified: 2022-01-02 14:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0
Sentry Crash Report:


Attachments
actions are added to actionCollection (3.55 KB, patch)
2008-08-15 20:14 UTC, Andi Clemens
Details
shortcuts editor (22.56 KB, image/png)
2008-12-17 13:38 UTC, Andi Clemens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alain Knaff 2007-08-29 23:04:32 UTC
Version:           0.9.2-final (using KDE 3.5.7, Kubuntu (gutsy) 4:3.5.7-1ubuntu14)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.22-10-generic

There are menu items, such as for instance Image->AdjustExifOrientationTag->RotatedLeft which are not bindable to a keyboard shortcut using Settings->ConfigureShortcuts

[Such a shortcut would be very handy to work around the slow physical rotation (interactively set the exif, and then commit using "Autorotate/Flip using Exif information"). However, as the exif rotation is buried so deeply in the menues, there's no actual speed win, as it takes as much time locating it than it would to "physically" rotate the image.]
Comment 1 Andi Clemens 2008-08-15 20:14:00 UTC
Created attachment 26864 [details]
actions are added to actionCollection 

With this patch it is possible to set custom keyboard shortcuts, however the
names in the config dialog are not too precise. For example the first action
will be found under "Normal", but it would be better to call it "Exif
Orientation - Normal". But this is already the menu entry caption... any
suggestions for that? Is this patch still needed anyway?

Andi
Comment 2 Andi Clemens 2008-08-16 14:03:59 UTC
Gilles,

I've seen that there are some kind of subcategories in the shortcuts settings dialog, for example "General" or every imageplugin has its own category. How is this done, I can't figure it out. Maybe we could generate a category "Exif
Orientation Settings" and groups those actions in there, so it will be visually clear what the action "normal" is referring to.

Andi
Comment 3 caulier.gilles 2008-12-05 22:41:35 UTC
Andi,

I remember to have check this report with 0.10.0 code... Right ?

Gilles 
Comment 4 Andi Clemens 2008-12-05 22:50:50 UTC
I need to re-check this again... and I need to ask you some question then, too :-)
But not today... all those bugreports today melte my brain ;-)

Andi
Comment 5 caulier.gilles 2008-12-08 12:47:03 UTC
Andi,

To remember :

from http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKAction.html we can read:

"Mixing QActions and KActions in an application is not a good idea. KShortcutsEditor doesn't handle QActions at all."

This is true with some QAction plugged to KXmlGuiWindow. There are generaly declared in private class as these one:
 
http://lxr.kde.org/source/extragear/graphics/digikam/digikam/digikamappprivate.h#236

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/cameragui/camerauiprivate.h#154

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/lighttable/lighttablewindowprivate.h#109

http://lxr.kde.org/source/extragear/graphics/digikam/showfoto/showfoto.cpp#153

Gilles Caulier
Comment 6 Andi Clemens 2008-12-08 18:19:04 UTC
Yes, right... some actions in digiKam are QActions, some are not registered in ActionCollection etc. We need to check for this, too.
Comment 7 Andi Clemens 2008-12-08 18:37:16 UTC
Somehow the shortcut editor seems to be completely broken, at least on my system (but only in digiKam).
If I open the shortcut editor, all shortcuts can be seen, but if I open it again, it is completely empty. I can repeat this like 1000 times, nothing happens.
Sometimes the "Export to HTML Gallery" plugin might appear in the config dialog, but on the next opening of the dialog it is gone again.

Can anyone confirm this?

Andi
Comment 8 Andi Clemens 2008-12-09 16:28:12 UTC
SVN commit 894894 by aclemens:

add Exif orientation actions to actionCollection, so they can be changed in the Shortcut Editor


 M  +48 -16    digikamapp.cpp

http://websvn.kde.org/?view=rev&revision=894894
Comment 9 Andi Clemens 2008-12-09 16:43:03 UTC
SVN commit 894898 by aclemens:

backport commit #894894

CCBUG:149360

 M  +17 -0     digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=894898
Comment 10 Andi Clemens 2008-12-10 18:57:07 UTC
It is really hard to find out if there are still some actions missing in the shortcut editor, but the ones mentioned in the original post have been added.

I think we can close this now. If needed later, it can be re-opened.

Andi
Comment 11 Andi Clemens 2008-12-17 13:38:23 UTC
Created attachment 29393 [details]
shortcuts editor

Something is definitely broken with shortcuts in digiKam.
The screenshot was taken after removing the digikamrc file and starting with a fresh config file. No entries can be found. digikam is the only KDE4 program that has those issues, so it is not a general kdelibs problem. What are we doing wrong?

The shortcuts will be available after thousands of restarts, but they are gone again on the next opening of the shortcut editor.
Comment 12 caulier.gilles 2008-12-17 16:09:01 UTC
Andi,

I confirm this for AlbumGUI, not editor, LightTable and CameraGUI.

So the problem is only in digikamapp.cpp

Gilles
Comment 13 Andi Clemens 2008-12-17 17:38:14 UTC
Yes right, seems to work in the other components except digikamapp.
Hmm... I'll open a new bugreport.

Andi
Comment 14 caulier.gilles 2008-12-17 17:48:57 UTC
Andi, 

No need to open a new file. I sure that with beta5 it works fine. I think that a recent regression have been done with beta7... I re-open this file...

Gilles
Comment 15 Andi Clemens 2008-12-17 17:57:29 UTC
Really? I have this problem since a very long time (5 months?) and always thought it is my system. But since you confirmed it now and no other KDE4 app has the problem, I'm sure that we are doing something wrong.
I don't think it worked in beta5, but I can't test this now.

Andi