Bug 149006 - Allow colons in server passwords
Summary: Allow colons in server passwords
Status: RESOLVED UNMAINTAINED
Alias: None
Product: ksirc
Classification: Miscellaneous
Component: general (show other bugs)
Version: 1.3.12
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Andrew Stanley-Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-19 20:47 UTC by Frans Pop
Modified: 2010-02-20 19:30 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frans Pop 2007-08-19 20:47:43 UTC
Version:           1.3.12 (using KDE KDE 3.5.7)
Installed from:    Debian testing/unstable Packages
OS:                Linux

If there is a colon in a server password, ksirc will not parse that correctly and will fail to connect. The fairly trivial patch below fixes this.

I can see no real reason why colons in passwords should not be allowed. AFAICT, when the connect string is parsed, just interpreting the password as "anything after the second colon" should be OK.

--- kdenetwork-3.5.5/ksirc/dsirc.orig   2007-08-19 20:26:45.000000000 +0200
+++ kdenetwork-3.5.5/ksirc/dsirc        2007-08-19 20:26:55.000000000 +0200
@@ -114,8 +114,8 @@
 $nick=$opt_n || $ARGV[0] || $ENV{"SIRCNICK"} || $ENV{"IRCNICK"} || $username;
 $set{"FINGER"}=$ENV{"IRCFINGER"} || "keep your fingers to yourself";
 $set{"USERINFO"}=$ENV{"USERINFO"} || "yep, I'm a user";
-if ($server =~ /^\[([^\]]+)\]:([0-9]*):?([^:]*)$/
-    or $server =~ /^([^:]+):([0-9]*):?([^:]*)$/)
+if ($server =~ /^\[([^\]]+)\]:([0-9]*):?(.*)$/
+    or $server =~ /^([^:]+):([0-9]*):?(.*)$/)
 {
        ($server, $port, $pass)=($1, $2, $3);
 }
Comment 1 Frans Pop 2007-08-19 20:51:15 UTC
Just for your information.

The reason this issue is a problem for me is that the "bip" proxyserver requires passwords in the format <user>:<passwd>:<network> to connect to it.
Comment 2 Dario Andres 2010-02-20 19:30:41 UTC
KSIRC was confirmed to be unmaintained, and its main developer is not reachable.
Closing as UNMAINTAINED.

I suggest all the users to try other KDE IRC client alternatives like Konversation, Aki, or the Qt-only Quassel.

Regards