Bug 148925 - Light Table thumb bar not updated when deleting images
Summary: Light Table thumb bar not updated when deleting images
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: LightTable-Thumbbar (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-17 13:04 UTC by Paweł Marciniak
Modified: 2022-02-01 08:55 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.9.3

Attachments
solves bug #148925 (408 bytes, patch)
2007-08-17 13:06 UTC, Paweł Marciniak 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Paweł Marciniak 2007-08-17 13:04:39 UTC 
Version:           svn stable branch (using KDE KDE 3.5.7)
Installed from:    Compiled From Sources
OS:                Linux

When working with light table, deleting (moving to trash) an image doesn't cause the thumb bar to update, leaving dead entries for the deleted images.
Comment 1 Paweł Marciniak 2007-08-17 13:06:59 UTC 
Created attachment 21419 [details]
solves bug #148925

The clearing flag has not been initialized to false. It was only changed to
false at the end of light table clearing operation. After such clearing,
deleting images from the light table worked properly. Now it works even before
clearing.
Comment 2 caulier.gilles 2007-08-17 14:30:17 UTC 
This patch sound fine for me.

Gerhard, Marcel, Arnd,

Can someone can test and patch KDE3 and KDE4 implementation in svn if all is right ? 

Gilles Caulier
Comment 3 Gerhard Kulzer 2007-08-17 14:45:44 UTC 
SVN commit 701145 by gkulzer:

CCBUG:148925    Light table updates correctly now

 M  +1 -0      thumbbar.cpp  


--- branches/extragear/kde3/graphics/digikam/libs/thumbbar/thumbbar.cpp #701144:701145
@@ -82,6 +82,7 @@
     {
         dragging   = false;
         exifRotate = false;
+	clearing   = false;
         toolTip    = 0;
         firstItem  = 0;
         lastItem   = 0;
Comment 4 Gerhard Kulzer 2007-08-17 14:49:44 UTC 
Am Friday 17 August 2007 schrieb Gilles Caulier:
[bugs.kde.org quoted mail]

comitted and tested. I'll close the bug.
Gerhard
Comment 5 Gerhard Kulzer 2007-08-17 14:54:05 UTC 
*** Bug has been marked as fixed ***.