Bug 148772 - histogram should refresh after editor save
Summary: histogram should refresh after editor save
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: ImageEditor-Save (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-12 15:39 UTC by David Bremner
Modified: 2022-02-03 03:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.9.3


Attachments
Screen shot of the editor, with updated histogram (105.39 KB, image/jpeg)
2007-12-04 12:48 UTC, David Bremner
Details
Screen shot of the viewer, after editing, with the old histogram (100.39 KB, image/jpeg)
2007-12-04 12:49 UTC, David Bremner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Bremner 2007-08-12 15:39:51 UTC
Version:            (using KDE KDE 3.5.7)
Installed from:    Debian testing/unstable Packages

After using adjust levels, save, and close the image editor, the image in the viewer updates, but not the histogram.
Comment 1 caulier.gilles 2007-12-04 12:04:37 UTC
This is not reproductible here...

Gilles Caulier
Comment 2 David Bremner 2007-12-04 12:48:38 UTC
Created attachment 22333 [details]
Screen shot of the editor, with updated histogram
Comment 3 David Bremner 2007-12-04 12:49:52 UTC
Created attachment 22334 [details]
Screen shot of the viewer, after editing, with the old histogram
Comment 4 David Bremner 2007-12-04 12:58:56 UTC
Maybe I did not explain myself well enough? I attach a couple of screenshots which might help.  I just verified the bug on a 16bit PNG, with digikam 9.3-svn from 2007-11-27.

I don't think it is something very special to my environment (unless it is a debian issue), because I originally reported the bug on a different machine
best,

David
Comment 5 David Bremner 2007-12-04 13:01:12 UTC
P.S. Leaving the album and re-entering rebuilds the histogram, so it looks like 
some caching issue.

Comment 6 caulier.gilles 2007-12-04 13:07:06 UTC
Ok, now i understand. It's a memory cache problem used by multithreaded image loading interface...

Marcel, can you reproduce it ?

Gilles
Comment 7 Marcel Wiesweg 2007-12-04 18:48:27 UTC
Yes I can reproduce it. If you select the next image and go back the histogram is realoaded, so I assume it is not a problem with the cache, but the update is not triggered.
It seems that AlbumIconView::refreshItems(KUrl::List) will should get called from signals from ImageWindow. I still need to check if this is the case as it should, and if this method or others trigger a redraw of the histogram sidebar.
Comment 8 Marcel Wiesweg 2007-12-06 20:42:41 UTC
SVN commit 745672 by mwiesweg:

Improve a condition that is meant to filter out duplicate calls, but filters too much.
Restrict to the time while loading.

BUG: 148772


 M  +7 -2      imagepropertiescolorstab.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=745672