Bug 148376 - Javascript syntax highlightning update
Summary: Javascript syntax highlightning update
Status: RESOLVED WORKSFORME
Alias: None
Product: kate
Classification: Applications
Component: syntax (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords: investigated, triaged
Depends on:
Blocks:
 
Reported: 2007-07-31 00:21 UTC by Tadas Šubonis
Modified: 2018-10-27 03:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
update (43.84 KB, text/plain)
2007-07-31 00:22 UTC, Tadas Šubonis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tadas Šubonis 2007-07-31 00:21:54 UTC
Version:           kate (using KDE KDE 3.5.7)
Installed from:    Unspecified

I heavily updated javascript syntax highlightning ;).
Comment 1 Tadas Šubonis 2007-07-31 00:22:42 UTC
Created attachment 21305 [details]
update
Comment 2 Pino Toscano 2007-07-31 00:34:37 UTC
Could you give a brief overview about the changes you did to it?
Comment 3 Tadas Šubonis 2007-07-31 10:37:59 UTC
Methods and properties are now in different lists. Full DOM (IE and Gecko) syntax highlightning, added more objects, style properties and some more.
Comment 4 Anders Lund 2007-10-17 19:48:47 UTC
This update contains problems. The methods list is tried in the root context, so that a very common variable name 'item' is highlighted in red when passed as an argument. I think the methods keyword list should only be tried when relevant, since it contains several common words.

Same goes for some of the other lists, the 'properties' list most prominently. Are those relevant without a parent object (object.property, object.method)?

The red color used is also not a good idea, as it is the default color for strings.

Finally, the update does not adhere the indentation profile of the file, indenting with 2 spaces. These issues, as a minimum, needs to be addressed. There may be more, I only did a quick test with a few files.
Comment 5 Tadas Šubonis 2007-10-17 20:53:30 UTC
I only added some more text to highlight. I am not capable of managing highlighting rules so maybe someone other could try to fix this.
Comment 6 Anders Lund 2007-10-22 15:39:54 UTC
Ok, I'll try to find time for it at some point :)
Comment 7 Christoph Cullmann 2011-08-12 08:16:18 UTC
Sorry, nobody had time to fix this.
Perhaps resubmit a new patch to current kate.git (like seen on kate-editor.org).
Comment 8 Andrew Crouthamel 2018-09-22 02:08:44 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 9 Andrew Crouthamel 2018-10-27 03:29:09 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!