Bug 147689 - cameras.xml file not closed
Summary: cameras.xml file not closed
Status: RESOLVED NOT A BUG
Alias: None
Product: digikam
Classification: Applications
Component: Setup-Cameras (show other bugs)
Version: unspecified
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-09 04:46 UTC by M. Asselstine
Modified: 2022-01-20 16:03 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.6.0

Attachments
possible fix (341 bytes, patch)
2007-07-09 04:50 UTC, M. Asselstine 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description M. Asselstine 2007-07-09 04:46:25 UTC 
Version:           cvs HEAD (using KDE KDE 3.5.5)
Installed from:    Debian stable Packages
OS:                Linux

In examining the digikam code base in subversion I notice that CameraList::load() does not close the file opened in the function. This will of course not necessarily crash the application but is not generally a good idea and I suspect that it was just missed.
Comment 1 M. Asselstine 2007-07-09 04:50:13 UTC 
Created attachment 21094 [details]
possible fix
Comment 2 caulier.gilles 2007-07-10 22:35:09 UTC 
Asselstine,

No need to call close() method, it closed when QFile instance is destroyed. Look here :

http://doc.trolltech.com/3.3/qfile#~QFile

So it's done automaticly by Qt.

Gilles Caulier