Bug 147670 - Compilation problems on NetBSD in greycstoration
Summary: Compilation problems on NetBSD in greycstoration
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Compilation (show other bugs)
Version: unspecified
Platform: NetBSD pkgsrc NetBSD
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-08 10:54 UTC by Thomas Klausner
Modified: 2017-08-19 20:58 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.9.3

Attachments
First part of the patch (757 bytes, patch)
2007-07-08 10:55 UTC, Thomas Klausner 		Details
Second part of the patch (716 bytes, patch)
2007-07-08 10:56 UTC, Thomas Klausner 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Klausner 2007-07-08 10:54:21 UTC 
Version:           0.9.2 (using KDE KDE 3.5.7)
Installed from:    NetBSD pkgsrc
Compiler:          gcc (GCC) 4.1.3 20070620 prerelease (NetBSD nb1 20070620) 
OS:                NetBSD

The code in digikam/libs/greycstoration has platform checks (ewwww, please use autoconf or cmake for this!) and is missing a case for NetBSD.
I'll attach patches to fix the problem.
Comment 1 Thomas Klausner 2007-07-08 10:55:36 UTC 
Created attachment 21084 [details]
First part of the patch
Comment 2 Thomas Klausner 2007-07-08 10:56:29 UTC 
Created attachment 21085 [details]
Second part of the patch
Comment 3 caulier.gilles 2007-07-10 22:56:55 UTC 
SVN commit 686232 by cgilles:

digiKam from KDE3 branch : fix NetBSD compatibilty tests
BUG: 147670


 M  +1 -1      CImg.h  
 M  +1 -1      greycstorationiface.cpp  


--- branches/extragear/kde3/graphics/digikam/libs/greycstoration/CImg.h #686231:686232
@@ -77,7 +77,7 @@
 // Try to detect the current system and set value of 'cimg_OS'.
 #ifndef cimg_OS
 #if defined(sun)         || defined(__sun)      || defined(linux)       || defined(__linux) \
- || defined(__linux__)   || defined(__CYGWIN__) || defined(BSD)         || defined(__FreeBSD__) \
+ || defined(__linux__)   || defined(__CYGWIN__) || defined(BSD)         || defined(__FreeBSD__) || defined (__NetBSD__) \
  || defined(__OPENBSD__) || defined(__MACOSX__) || defined(__APPLE__)   || defined(sgi) \
  || defined(__sgi)
 // Unix-like (Linux, Solaris, BSD, MacOSX, Irix,...).
--- branches/extragear/kde3/graphics/digikam/libs/greycstoration/greycstorationiface.cpp #686231:686232
@@ -38,7 +38,7 @@
 
 #define cimg_plugin "greycstoration.h"
 #if defined(sun)         || defined(__sun)      || defined(linux)       || defined(__linux) \
- || defined(__linux__)   || defined(__CYGWIN__) || defined(BSD)         || defined(__FreeBSD__) \
+ || defined(__linux__)   || defined(__CYGWIN__) || defined(BSD)         || defined(__FreeBSD__) || defined(__NetBSD__)\
  || defined(__OPENBSD__) || defined(__MACOSX__) || defined(__APPLE__)   || defined(sgi) \
  || defined(__sgi)
 #include <pthread.h>
Comment 4 caulier.gilles 2007-07-10 22:59:35 UTC 
SVN commit 686237 by cgilles:

backport NETBSD fix from KDE3 branch
CCBUGS: 147670


 M  +1 -1      CImg.h  
 M  +1 -1      greycstorationiface.cpp  


--- trunk/extragear/graphics/digikam/libs/greycstoration/CImg.h #686236:686237
@@ -77,7 +77,7 @@
 // Try to detect the current system and set value of 'cimg_OS'.
 #ifndef cimg_OS
 #if defined(sun)         || defined(__sun)      || defined(linux)       || defined(__linux) \
- || defined(__linux__)   || defined(__CYGWIN__) || defined(BSD)         || defined(__FreeBSD__) \
+ || defined(__linux__)   || defined(__CYGWIN__) || defined(BSD)         || defined(__FreeBSD__) || defined (__NetBSD__) \
  || defined(__OPENBSD__) || defined(__MACOSX__) || defined(__APPLE__)   || defined(sgi) \
  || defined(__sgi)
 // Unix-like (Linux, Solaris, BSD, MacOSX, Irix,...).
--- trunk/extragear/graphics/digikam/libs/greycstoration/greycstorationiface.cpp #686236:686237
@@ -34,7 +34,7 @@
 
 #define cimg_plugin "greycstoration.h"
 #if defined(sun)         || defined(__sun)      || defined(linux)       || defined(__linux) \
- || defined(__linux__)   || defined(__CYGWIN__) || defined(BSD)         || defined(__FreeBSD__) \
+ || defined(__linux__)   || defined(__CYGWIN__) || defined(BSD)         || defined(__FreeBSD__) || defined(__NetBSD__)\
  || defined(__OPENBSD__) || defined(__MACOSX__) || defined(__APPLE__)   || defined(sgi) \
  || defined(__sgi)
 #include <pthread.h>