Bug 147115 - hardware sensor alarm minimum and maximum voltage settings are rounded to the nearest integer value when program restarted
Summary: hardware sensor alarm minimum and maximum voltage settings are rounded to the...
Status: RESOLVED FIXED
Alias: None
Product: ksysguard
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-23 02:56 UTC by Karl Scheel
Modified: 2008-12-06 11:49 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Scheel 2007-06-23 02:56:52 UTC
Version:           1.2.0 (using KDE 3.5.5 "release 45.4" , openSUSE 10.2)
Compiler:          Target: i586-suse-linux
OS:                Linux (i586) release 2.6.18.8-0.3-default

I setup hardware health monitoring by loading the correct modules for a Winbond W83781D hardware health monitoring chip into the kernel; the application "sensors" works fine, but this application is non-graphical (i.e., too plain). Following my discovery that ksysguard could be configured to display voltage, temperature, and fan RPM data in a graphical format, I proceeded to do so; I displayed these data in multimeter format, entering minimum and maximum values for voltage within the Properties dialogue with precision to three decimal places. I found these settings worked perfectly until I quit the program and then restarted it; upon restart, I found that the forground colours on some meters were in the red. When I reopened the Properties dialogue for the values in question, I found that the fractional components of my voltage threshold settings had completely disappeared; they were each replaced with integer values. The same was true for all voltage threshold settings. For example, the 3.46V maximum threshold and 3.14V minimum threshold for the 3.3V channel that was displayed became 3V and 3V due to rounding. That is not precise enough: It's no wonder that this meter was always in the red! When I tried re-entering these voltage thresholds with single-digit precision, I found that the exact same behaviour occurred. I did not have any problem with the temperature or fan RPM thresholds; that's because I used only integers for these.
Comment 1 Karl Scheel 2007-06-23 03:06:26 UTC
A modification to this application is required to enable fractional numbers to be stored upon exit and retrieved upon restart. This is necessary because it has been demonstrated that these types of numbers are necessary to prevent false triggering of alarms. 
Comment 2 John Tapsell 2008-12-06 11:49:43 UTC
SVN commit 893225 by johnflux:

Save the upper/lower limit values as doubles, not longs.
Sorry for taking so long to fix this bug - I'm ashamed.

BUG:147115



 M  +5 -5      MultiMeter.cc  


WebSVN link: http://websvn.kde.org/?view=rev&revision=893225