Bug 146921 - can't forward inline emails
Summary: can't forward inline emails
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Unmaintained
Component: general (show other bugs)
Version: 1.9.7
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-18 16:14 UTC by Elan Ruusamäe
Modified: 2008-12-21 23:53 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elan Ruusamäe 2007-06-18 16:14:12 UTC
Version:           1.9.7 (using KDE 3.5.7, PLD Linux Distribution)
Compiler:          gcc version 3.3.6 (PLD Linux)
OS:                Linux (x86_64) release 2.6.16.38-1

i can't forward inline (shift+F) emails that-
1. are without content-type
2. have content-type!=text/plain

that is i can forward content-type=text/plain emails correctly.
most odd is the 1) because those are displayed as text/plain emails (mostly cron emails)
Comment 1 Thomas McGuire 2007-06-18 19:23:43 UTC
Am I correct in my assumption that this is another duplicate of bug 140549?

You did not tell in which way it fails.
Comment 2 Elan Ruusamäe 2007-06-19 12:02:15 UTC
sorry about that, instead of forwarding inline, kmail attaches the original email body as text/plain (just like plain forward (F) works, except the content-type is text/plain not message/rfc822)

and if i forward multipart (html+text) it attaches inline the text part (that is expected)

not sure is it duplicate because i don't use templates.
Comment 3 Thomas McGuire 2007-06-22 14:41:46 UTC
Maybe a dupe of bug 141301 then.
There, the mail is also attached, instead adding the text inline.
Not sure if these are the same cirumstances though, I have to admit I am a bit confused about all the content-type/multipart/etc stuff.
Comment 4 Thomas McGuire 2008-12-21 16:38:23 UTC
SVN commit 899776 by tmcguire:

Fix inline-forwarding of messages with attachments.

The template parser copied the original message and then set the whole body to the template text.
This did not work for multipart messages, since setting the body there has no effect (and would
discard the attachment if it had any effect).
Therefore, we simply place the template text in the first text part we find in case of multipart
messages. This probably still breaks with HTML messages with attachments or with other complicated
nested structures. Oh well.

BUG: 178128
BUG: 146921


 M  +61 -43    kmmessage.cpp  
 M  +68 -35    kmmessage.h  
 M  +12 -2     templateparser.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=899776
Comment 5 Thomas McGuire 2008-12-21 23:53:12 UTC
SVN commit 899972 by tmcguire:

Backport r899776 by tmcguire from trunk to the 4.1 branch:

Fix inline-forwarding of messages with attachments.

The template parser copied the original message and then set the whole body to the template text.
This did not work for multipart messages, since setting the body there has no effect (and would
discard the attachment if it had any effect).
Therefore, we simply place the template text in the first text part we find in case of multipart
messages. This probably still breaks with HTML messages with attachments or with other complicated
nested structures. Oh well.

CCBUG: 178128
CCBUG: 146921
kolab/issue 3219



 M  +61 -43    kmmessage.cpp  
 M  +68 -35    kmmessage.h  
 M  +12 -2     templateparser.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=899972