Bug 146513 - Horizontal active desktop borders don't work
Summary: Horizontal active desktop borders don't work
Status: RESOLVED WORKSFORME
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: RedHat Enterprise Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-07 21:06 UTC by Carsten
Modified: 2007-10-09 05:14 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Kicker screenshot, four desktops in one row (45.18 KB, image/png)
2007-06-21 16:13 UTC, lenz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten 2007-06-07 21:06:44 UTC
Version:            (using KDE KDE 3.5.7)
Installed from:    RedHat RPMs

Hey!

After upgrading KDE 3.5.7 release 23.1 to 31.1, I find my desktop-borders behaving pretty funky. I often drag windows from one dektop to another, which isn't possible by dragging them horizontally anymore. It does work vertically, though, but this is not what I am used to. The respective settings in KControl are correct and it doesn't change by simply deactiving / reactivating actice desktop-borders.

I found someone else having the same problems, also on a SuSE 10.2 (thread is in german), so it seems a reproduceable bug.

http://www.unixboard.de/vb3/showthread.php?t=30688

gropiuskalle
Comment 1 Maf. King 2007-06-10 11:59:48 UTC
Hi,
I see this too, still exists in the OpenSuSE 3.5.7 "release 35.1" packages.

--Maf.
Comment 2 lenz 2007-06-11 10:20:06 UTC
I can confirm this behaviour (openSUSE 10.2, kdebase3-3.5.7-23.2 from http://software.opensuse.org/download/KDE:/KDE3/openSUSE_10.2), the previously active desktop borders to the left and right have switched to be on the top and bottom of the screen, which in my case is a bit annoying as I have an autohiding panel on the top of the desktop which I now can not access anymore... (see bug#92764)
Comment 3 Lubos Lunak 2007-06-11 11:55:09 UTC
Already fixed.
Comment 4 Carsten 2007-06-20 18:36:53 UTC
Sorry, but I'll have to reopen this bug - it was perfectly fixed with todays release 39.1, but after upgrading to release 43.1, switching desktops malfunctions  again. The borders are not shut anymore, but depending on the chosen desktop the window will be dragged wrong. I have four virtual desktops, dragging a window from  #1 to #2 works fine, but dragging it from #2 to #3 will drop the window on #1 again. I will report this to the openSuSE-buildservice as well.

Thank you for taking care.
Comment 5 Lubos Lunak 2007-06-21 14:30:18 UTC
Works fine here. What are the steps to reproduce the problem with a fresh user account?
Comment 6 lenz 2007-06-21 16:12:26 UTC
Hi Lubos, thanks a lot for looking into this. I've just updated to the latest KDE RPMs from the openSUSE Buildservice (kdebase3-3.5.7-31.1) and re-enabled active desktop borders again.

The behaviour has changed somewhat, but has not improved (at least for me).

I guess it depends on how the virtual desktops are laid out when looking at the desktop pager in the kicker panel. I use a very small icon size for the panel  and I configured the pager to display them in one row, so my desktops (1-4) are laid out next to each other (see attached screen shot).

Therefore I'd expect that I just have to switch desktops by moving the mouse cursor to the left or right of the screen (or pressing CTRL+ALT+LEFT/RIGHT in my configuration), not the top or bottom. This used to work fine in previous versions, but now moving left/right only switches between desktop 1/2 or 3/4, while moving up/down switches between 2/4 and 1/3.

It would be nice if the possible movement directions between the desktops matches the chosen layout/arrangement as displayed in the pager. If all desktops are put in one line, the movement between those should only require movement to the left and right, not up and down.

If you arrange the four desktops in a square, it seems to work as expected:

 +---+---+
 | 1 | 2 |
 +---+---+
 + 3 | 4 |
 +---+---+

Left/Right switches between 1/2 or 3/4
Up/Down switches between 1/3 or 2/4

However, my pager displays the desktops like this:

 +---+---+---+---+
 | 1 | 2 | 3 | 4 |
 +---+---+---+---+

Left/Right should now switch between 1/2/3/4
Up/Down should not cause a desktop switch!

I hope this explains the problem we're facing. Thanks!
Comment 7 lenz 2007-06-21 16:13:43 UTC
Created attachment 20915 [details]
Kicker screenshot, four desktops in one row
Comment 8 Carsten 2007-06-21 16:51:58 UTC
lenz, thank you for pointing out what my problem is, for this is exactly the behavior of the desktops which I am experiencing. I also have my desktops ordered in one line, which propably is mostly common on very slim kickers, while most users will order them in two rows (at least that's what I see on many screenshots). Hope this gets fixed soon, because when being used to unclutter a desktop by dragging a window somewhere else, this is extremely annoying.
Comment 9 Lubos Lunak 2007-06-21 17:54:54 UTC
SVN commit 678521 by lunakl:

Add missing detection of changes for some properties.
BUG: 146513  



 M  +8 -0      netwm.cpp  


--- branches/KDE/3.5/kdelibs/kdecore/netwm.cpp #678520:678521
@@ -2124,6 +2124,14 @@
 		dirty |= ActiveWindow;
 	    else if (pe.xproperty.atom == net_showing_desktop)
 		dirty2 |= WM2ShowingDesktop;
+//            else if (pe.xproperty.atom == net_supported )
+//                dirty |= Supported; // update here?
+            else if (pe.xproperty.atom == net_supporting_wm_check )
+                dirty |= SupportingWMCheck;
+            else if (pe.xproperty.atom == net_virtual_roots )
+                dirty |= VirtualRoots;
+            else if (pe.xproperty.atom == net_desktop_layout )
+                dirty2 |= WM2DesktopLayout;
 	    else {
 
 #ifdef    NETWMDEBUG
Comment 10 lenz 2007-07-23 23:18:47 UTC
FWIW, the latest KDE packages from the openSUSE build service (kdebase3-3.5.7-57.2 et al) have finally resolved the issue for me. Thank you!
Comment 11 Carsten 2007-07-25 01:29:33 UTC
I don't get it - it *still* doesn't work for me (KDE 3.5.7 release 60.1).

So I reopen this bug...

If there's any information needed, please tell me.
Comment 12 Lubos Lunak 2007-08-10 13:29:42 UTC
I don't know what else to ask for. It should work now and I don't see why it doesn't for you.
Comment 13 Carsten 2007-10-09 05:14:46 UTC
Bug disappeared with my upgrade to SuSE 10.3 - guess in the end it wasn't a KDE-bug anymore but some bad configuration or whatever. Anyway, it's fixed.