Bug 146443 - Feature Request For Ktorrent display total time seeded on a torrent.
Summary: Feature Request For Ktorrent display total time seeded on a torrent.
Status: RESOLVED WORKSFORME
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-06 06:32 UTC by Dean Hilkewich
Modified: 2007-06-11 19:53 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Hilkewich 2007-06-06 06:32:59 UTC
Version:           2.2 (using KDE KDE 3.5.7)
Installed from:    SuSE RPMs
OS:                Linux

I would like to request actually a couple of things to be added to ktorrent.

1) Display total time seeded on a torrent that does not reset with client closure.
2) have the option of stopping a torrent after x number of hours seeding after completion.

They could probably be both added to the Use limit fuction.

ie:

Use Limit Max Ratio: 2.00 or 72 hours.


I have over a thousand members on my site using ktorrent and this is a very desired feature for them.
Comment 1 Tony Twist 2007-06-06 07:03:36 UTC
Heck ya.  Makes it a lot easier to keep track of how long your torrents have been seeded on private trackers where there is ratio/time rules.
Comment 2 Joris Guisson 2007-06-06 18:51:40 UTC
The question is were do we put all of this ? Another column in the view or on the infowidget.
Comment 3 Tony Twist 2007-06-06 23:50:59 UTC
Use Limit Max Ratio: 2.00 or 72 hours.  <--------- For this I would say where you can already set the ratio on the info widget 


1) Display total time seeded on a torrent that does not reset with client closure <--------- For that it could be a extra column or in the info widget as well under the ratio setting.
Comment 4 Jake C. 2007-06-07 05:11:42 UTC
I would think that they would be both good spots for the two mods, the column makes it easy to view and the info widget a good place to set the time seeded.
Comment 5 Joris Guisson 2007-06-10 13:43:18 UTC
SVN commit 673497 by guisson:

Changes :
- Add max seed time feature
- Add columns for time seeded and and time downloaded in view
- Fixed auto import not working anymore bug

BUG: 146443



 M  +2 -0      ChangeLog  
 M  +161 -127  apps/ktorrent/downloadpref.ui  
 M  +11 -5     apps/ktorrent/ktorrentcore.cpp  
 M  +7 -1      apps/ktorrent/ktorrentcore.h  
 M  +8 -2      apps/ktorrent/ktorrentview.cpp  
 M  +20 -0     apps/ktorrent/ktorrentviewitem.cpp  
 M  +2 -0      apps/ktorrent/pref.cpp  
 M  +35 -8     apps/ktorrent/trayicon.cpp  
 M  +8 -2      apps/ktorrent/trayicon.h  
 M  +20 -1     libktorrent/interfaces/torrentinterface.h  
 M  +5 -0      libktorrent/ktorrent.kcfg  
 M  +0 -2      libktorrent/torrent/multifilecache.cpp  
 M  +3 -4      libktorrent/torrent/queuemanager.cpp  
 M  +8 -0      libktorrent/torrent/singlefilecache.cpp  
 M  +35 -15    libktorrent/torrent/torrentcontrol.cpp  
 M  +7 -4      libktorrent/torrent/torrentcontrol.h  
 M  +5 -1      plugins/infowidget/floatspinbox.cpp  
 M  +49 -1     plugins/infowidget/statustab.cpp  
 M  +4 -3      plugins/infowidget/statustab.h  
 M  +207 -158  plugins/infowidget/statustabbase.ui  
Comment 6 Dean Hilkewich 2007-06-10 16:24:27 UTC
Sweet thanks.  Off to test.
Comment 7 Dean Hilkewich 2007-06-10 16:50:00 UTC
Sadly with this latest round of fixes it will no longer compile.

compiling ./plugins/infowidget/statustabbase.cpp
g++ -DHAVE_CONFIG_H -I./plugins/infowidget -I/home/dean/Desktop/ktorrent/plugins/infowidget -I. -I/home/dean/Desktop/ktorrent/plugins/infowidget/../../libktorrent -I/opt/kde3/include -I/usr/lib/qt3/include -I. -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -O2 -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -fexceptions -fPIC -DPIC -c ./plugins/infowidget/statustabbase.cpp -o ./plugins/infowidget/.libs/statustabbase.o -Wp,-MD,./plugins/infowidget/.deps/statustabbase.TUlo
./plugins/infowidget/statustabbase.cpp:22:36: error: kt::downloadedchunkbar.h: No such file or directory
./plugins/infowidget/statustabbase.cpp:23:38: error: kt::availabilitychunkbar.h: No such file or directory
./plugins/infowidget/statustabbase.cpp:24:30: error: kt::floatspinbox.h: No such file or directory
Error creating ./plugins/infowidget/statustabbase.lo. Exit status 1.
make: *** [all] Error 1

The svn compiled fine 2 days previous.
Comment 8 Dean Hilkewich 2007-06-10 17:13:07 UTC
Oddly enough the svn-snapshot ktorrent-2007-06-10.tar.gz does not reproduce same error.  Missing files in the svn perhaps?
Comment 9 Dean Hilkewich 2007-06-10 17:49:21 UTC
One more update after compiling the SVN snapshot I'm not seeing these improvements.  Are they not included in the svn-snapshot ktorrent-2007-06-10.tar.gz?
Comment 10 Joris Guisson 2007-06-11 08:12:25 UTC
Snapshot was made before these changes

As for the compile error, this is a bug in Qt Designer, it does not handle namespaces properly, I will fix this when I get home from work.
Comment 11 Joris Guisson 2007-06-11 18:30:09 UTC
OK, it should compile again
Comment 12 Dean Hilkewich 2007-06-11 19:53:59 UTC
Works now.  Thanks.