Bug 145744 - Compile error on Solaris 8 - kdebase/apps/konsole/src/start.cpp includes Xrender.h without including Xlib.h
Summary: Compile error on Solaris 8 - kdebase/apps/konsole/src/start.cpp includes Xren...
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Solaris
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-21 15:00 UTC by Steve Evans
Modified: 2007-05-21 16:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Include <X11/Xlib.h> (345 bytes, patch)
2007-05-21 15:01 UTC, Steve Evans
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Evans 2007-05-21 15:00:04 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.4.6 
OS:                Solaris

I get this compile error on Solaris:

[ 36%] Building CXX object apps/konsole/src/CMakeFiles/kdeinit_konsole.dir/start.o
In file included from /gorbag/exta/cad/externals/SOLARIS/include/X11/extensions/Xrender.h:33,
                 from /cad4/stevee/kde-svn/kdebase/apps/konsole/src/start.cpp:24:
/usr/include/X11/Xutil.h:117: error: `Bool' does not name a type
/usr/include/X11/Xutil.h:120: error: `Pixmap' does not name a type
/usr/include/X11/Xutil.h:121: error: `Window' does not name a type
/usr/include/X11/Xutil.h:123: error: `Pixmap' does not name a type
/usr/include/X11/Xutil.h:124: error: `XID' does not name a type
/usr/include/X11/Xutil.h:207: error: `XPointer' does not name a type
/usr/include/X11/Xutil.h:254: error: expected `;' before '*' token
/usr/include/X11/Xutil.h:255: error: `VisualID' does not name a type
/usr/include/X11/Xutil.h:287: error: `Colormap' does not name a type
/usr/include/X11/Xutil.h:295: error: `VisualID' does not name a type
/usr/include/X11/Xutil.h:296: error: `XID' does not name a type
/usr/include/X11/Xutil.h:365: error: `XRectangle' has not been declared
/usr/include/X11/Xutil.h:384: error: `XID' has not been declared
/usr/include/X11/Xutil.h:411: error: `XID' has not been declared
/usr/include/X11/Xutil.h:413: error: `XPointer' has not been declared
/usr/include/X11/Xutil.h:417: error: `Status' does not name a type
/usr/include/X11/Xutil.h:425: error: `Status' does not name a type
/usr/include/X11/Xutil.h:434: error: `Status' does not name a type
/usr/include/X11/Xutil.h:442: error: `Status' does not name a type
/usr/include/X11/Xutil.h:452: error: `Status' does not name a type

(plus many similar errors)

This is fixed by including <X11/Xlib.h> before <X11/extensions/Xrender.h>
Comment 1 Steve Evans 2007-05-21 15:01:29 UTC
Created attachment 20651 [details]
Include <X11/Xlib.h>
Comment 2 Robert Knight 2007-05-21 16:01:32 UTC
Fixed (rv. #666992).  Perhaps a bug report should be filed against the providers of the Xrender header file in addition, since it should (and does on my Linux installation) include everything it requires.
Comment 3 Steve Evans 2007-05-21 16:43:39 UTC
The Xrender I have installed on Solaris is version 0.8.3, which doesn't include Xlib.h. Version 0.9.2 of Xrender does include it. However I had a lot of difficulty getting Xrender to work on Solaris and now that it is working I am reluctant to touch it unless I have to.