Bug 145482 - Compile fails under Windows
Summary: Compile fails under Windows
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Compilation (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-16 04:38 UTC by Yaakov Selkowitz
Modified: 2023-11-29 06:27 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.2.0
Sentry Crash Report:


Attachments
libkdcraw/dcrawbinary.cpp patch (1.59 KB, patch)
2007-05-16 04:39 UTC, Yaakov Selkowitz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yaakov Selkowitz 2007-05-16 04:38:29 UTC
Version:            (using KDE KDE 3.5.6)
Installed from:    Compiled From Sources
Compiler:          gcc 3.4.4 
OS:                Cygwin

libkdcraw/dcrawbinary.cpp defines a QString named stdout.  On some platforms, including Cygwin, this is misinterpreted as the literal __FILE* stdout, and leads to a compile error.  Renaming the variable allows the build to proceed.

I'm attaching a patch to fix this issue.
Comment 1 Yaakov Selkowitz 2007-05-16 04:39:02 UTC
Created attachment 20580 [details]
libkdcraw/dcrawbinary.cpp patch
Comment 2 caulier.gilles 2007-05-16 07:34:47 UTC
SVN commit 665182 by cgilles:

libkdcraw from trunk : patch to compile under CYGWIN
BUG: 145482


 M  +2 -2      dcrawbinary.cpp  


--- trunk/extragear/libs/libkdcraw/dcrawbinary.cpp #665181:665182
@@ -96,8 +96,8 @@
     // The dcraw output looks like this : Raw photo decoder "dcraw" v8.54...
     QString dcrawHeader("Raw photo decoder \"dcraw\" v");
 
-    QString stdout    = QString::fromLocal8Bit(buffer, buflen);
-    QString firstLine = stdout.section('\n', 1, 1);    
+    QString dcrawOut  = QString::fromLocal8Bit(buffer, buflen);
+    QString firstLine = dcrawOut.section('\n', 1, 1);    
 
     if (firstLine.startsWith(dcrawHeader))
     {