Bug 145369 - I can't maximize the Ktorrent window with the screen at 1024x768
Summary: I can't maximize the Ktorrent window with the screen at 1024x768
Status: RESOLVED FIXED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
: 147958 148123 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-05-13 04:57 UTC by Alejandro Diaz Caro
Modified: 2007-07-23 09:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
This is a snapshot of the window maximized showing the state tab (98.48 KB, image/png)
2007-07-08 15:28 UTC, Alejandro Diaz Caro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro Diaz Caro 2007-05-13 04:57:34 UTC
Version:           2.1.4 (using KDE 3.5.6, Kubuntu (feisty) 4:3.5.6-0ubuntu14)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.20-15-generic

I have configured my screen to 1024x768, and I can't maximize the Ktorrent window because it overflows the screen.
Here you can see how the ktorrent window looks like after I maximize it: http://www.fceia.unr.edu.ar/~diazcaro/ktorrent.jpg
Comment 1 Joris Guisson 2007-05-15 19:26:49 UTC
What if you manually resize it ? Can you get it smaller then the screen width ?
Comment 2 Alejandro Diaz Caro 2007-05-15 20:07:33 UTC
No, I can't. But this only happen when I am downloading something, if I don't, I can resize the window normally.
Comment 3 Joris Guisson 2007-05-15 20:22:11 UTC
It must be one of the tabs which gets to big when you are downloading. I'm guessing it's the trackers tab (probably the last one). In the settings you can hide this tab, can you disable it and see what that gives ?

Comment 4 Alejandro Diaz Caro 2007-05-15 20:33:33 UTC
Yes, you are right. The problem is the trakers tab, when I disable it, I can get the window smaller than the screen width.
Comment 5 Joris Guisson 2007-05-17 10:28:41 UTC
I'm gonna see what takes up the most space in Spanish, and try to get that smaller. 
Comment 6 Joris Guisson 2007-05-17 10:42:25 UTC
SVN commit 665574 by guisson:

There is no need to use Tracker URL and Tracker status in the trackers tab, URL and Status do just fine.
This should also fix the problem of the window getting to big in 1024x768 with the Spanish translation when a torrent is downloading.

BUG: 145369



 M  +5 -2      trackerviewbase.ui  


--- trunk/extragear/network/ktorrent/plugins/infowidget/trackerviewbase.ui #665573:665574
@@ -20,6 +20,9 @@
             <verstretch>0</verstretch>
         </sizepolicy>
     </property>
+    <property name="caption">
+        <string>TrackerViewBase</string>
+    </property>
     <grid>
         <property name="name">
             <cstring>unnamed</cstring>
@@ -53,7 +56,7 @@
                                 </sizepolicy>
                             </property>
                             <property name="text">
-                                <string>Tracker URL:</string>
+                                <string>URL:</string>
                             </property>
                         </widget>
                         <widget class="KSqueezedTextLabel">
@@ -102,7 +105,7 @@
                                 </sizepolicy>
                             </property>
                             <property name="text">
-                                <string>Tracker status:</string>
+                                <string>Status:</string>
                             </property>
                         </widget>
                         <widget class="QLabel">
Comment 7 Alejandro Diaz Caro 2007-05-17 21:46:20 UTC
Thank you very much!
Comment 8 Alejandro Diaz Caro 2007-07-08 15:10:57 UTC
On version 2.2 there is a similar problem. Now, the problem is the "Estado" (State) tab. This tab is too big and, again, the window overflows the screen (at 1024x768).
Comment 9 Alejandro Diaz Caro 2007-07-08 15:12:14 UTC
I reopen this bug.
Comment 10 Alejandro Diaz Caro 2007-07-08 15:28:34 UTC
Created attachment 21087 [details]
This is a snapshot of the window maximized showing the state tab
Comment 11 Joris Guisson 2007-07-09 12:55:52 UTC
It's not the status tab, but the status bar. 

Why must Spanish take up so much space ? 
Comment 12 Alejandro Diaz Caro 2007-07-09 16:14:14 UTC
No, I tell you "STATE TAB", not "STATUS". I don't know if this tab's name is "state" in english, but the translation from "estado" is "state"

It's the tab that you can see on the attached screenshot
Comment 13 Joris Guisson 2007-07-09 20:07:48 UTC
SVN commit 685766 by guisson:

Changes :
- Fix keep seeding
- Replace possibly firewalled stuff with a warning icon (with tooltip showing the old text), this also makes sure that the statusbar does not become to big

BUG: 145369



 M  +2 -1      apps/ktorrent/ktorrent.cpp  
 M  +2 -0      libktorrent/torrent/queuemanager.cpp  


--- branches/extragear/kde3/network/ktorrent/apps/ktorrent/ktorrent.cpp #685765:685766
@@ -163,7 +163,8 @@
 	m_statusTransfer = new QLabel(this);
 	m_statusDHT = new QLabel(this);
 	m_statusFirewall = new QLabel(this);
-	m_statusFirewall->setText(i18n("No incoming connections (possibly firewalled)")); // this will be hidden when we see an incoming connection
+	m_statusFirewall->setPixmap(SmallIcon("messagebox_warning"));
+	QToolTip::add(m_statusFirewall,i18n("No incoming connections (possibly firewalled)"));
 
 	statusBar()->addWidget(m_statusFirewall);
 	statusBar()->addWidget(m_statusInfo,1);
--- branches/extragear/kde3/network/ktorrent/libktorrent/torrent/queuemanager.cpp #685765:685766
@@ -598,6 +598,8 @@
 
 		if (keep_seeding)
 		    torrentAdded(tc, false, false);
+		else
+			stop(tc,true);
 
 		orderQueue();
 	}
Comment 14 Joris Guisson 2007-07-09 20:14:09 UTC
No it is the status bar, if you don't believe me hide the status bar (in the Settings menu)
Comment 15 Alejandro Diaz Caro 2007-07-09 20:16:12 UTC
Yes! You are right! Thanks again :)
Comment 16 Bram Schoenmakers 2007-07-17 23:44:46 UTC
*** Bug 147958 has been marked as a duplicate of this bug. ***
Comment 17 Joris Guisson 2007-07-23 09:55:36 UTC
*** Bug 148123 has been marked as a duplicate of this bug. ***