Bug 144939 - Startup hint about image dates refers to non-existing menu option
Summary: Startup hint about image dates refers to non-existing menu option
Status: RESOLVED FIXED
Alias: None
Product: kphotoalbum
Classification: Applications
Component: general (show other bugs)
Version: SVN (KDE3 branch)
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: KPhotoAlbum Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-01 22:11 UTC by Gerke Kok
Modified: 2007-08-09 19:50 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gerke Kok 2007-05-01 22:11:09 UTC
Version:           SVN (using KDE 3.5.6, compiled sources)
Compiler:          Target: i586-mandriva-linux-gnu
OS:                Linux (i686) release 2.6.17-13mdvlegacy

The startup hint about incomplete date/time refers to a menu option in the Maintenance menu that does not exist. This is the menu option about (re)reading the date/time information from EXIF.
Comment 1 Shawn Willden 2007-05-10 15:36:36 UTC
Can you look at Help->KPhotoAlbum Feature Status and see if EXIF info is supported?  I suspect the menu item isn't there because you don't have EXIF support.  If that's the case, I'd suggest you make sure you have libexiv2 installed and then try building again.

In any case, I'll look at modifying that message based on the presence of EXIF support.
Comment 2 Jan Kundrát 2007-08-09 19:49:59 UTC
SVN commit 698274 by jkt:

Don't suggest using EXIF stuff when we have no libexiv2 and images aren't
ordered properly
BUG: 144939


 M  +10 -1     branches/extragear/kde3/graphics/kphotoalbum/XMLDB/FileReader.cpp  
 M  +10 -1     branches/work/kphotoalbum-iptc/XMLDB/FileReader.cpp  
 M  +10 -1     trunk/extragear/graphics/kphotoalbum/XMLDB/FileReader.cpp  


--- branches/extragear/kde3/graphics/kphotoalbum/XMLDB/FileReader.cpp #698273:698274
@@ -254,15 +254,24 @@
 
     if ( wrongOrder ) {
         KMessageBox::information( MainWindow::Window::theMainWindow(),
+#ifdef HASEXIV2
                                   i18n("<p>Your images/videos are not sorted, which means that navigating using the date bar "
                                        "will only work suboptimally.</p>"
                                        "<p>In the <b>Maintenance</b> menu, you can find <b>Display Images with Incomplete Dates</b> "
                                        "which you can use to find the images that are missing date information.</p>"
                                        "You can then select the images that you have reason to believe have a correct date "
-                                       "in either their EXIF data or on the file, and execute <b>Maintainance->Read EXIF Info</b> "
+                                       "in either their EXIF data or on the file, and execute <b>Maintenance->Read EXIF Info</b> "
                                        "to reread the information.</p>"
                                        "<p>Finally, once all images have their dates set, you can execute "
                                        "<b>Images->Sort Selected by Date & Time</b> to sort them in the database.</p>"),
+#else
+                                  i18n("<p>Your images/videos are not sorted, which means that navigating using the date bar "
+                                       "will only work suboptimally.</p>"
+                                       "<p>You also don't have EXIF support available, which means that you can't read "
+                                       "image dates from JPEG metadata. It's strongly recommended to recompile KPhotoAlbum "
+                                       "with the <code>exiv2</code> library. After you have done so, you'll be asked what "
+                                       "to do to correct all missing information.</p>"),
+#endif
                                   i18n("Images/Videos Are Not Sorted"),
                                   QString::fromLatin1( "checkWhetherImagesAreSorted" ) );
     }
--- branches/work/kphotoalbum-iptc/XMLDB/FileReader.cpp #698273:698274
@@ -254,15 +254,24 @@
 
     if ( wrongOrder ) {
         KMessageBox::information( MainWindow::Window::theMainWindow(),
+#ifdef HASEXIV2
                                   i18n("<p>Your images/videos are not sorted, which means that navigating using the date bar "
                                        "will only work suboptimally.</p>"
                                        "<p>In the <b>Maintenance</b> menu, you can find <b>Display Images with Incomplete Dates</b> "
                                        "which you can use to find the images that are missing date information.</p>"
                                        "You can then select the images that you have reason to believe have a correct date "
-                                       "in either their EXIF data or on the file, and execute <b>Maintainance->Read EXIF Info</b> "
+                                       "in either their EXIF data or on the file, and execute <b>Maintenance->Read EXIF Info</b> "
                                        "to reread the information.</p>"
                                        "<p>Finally, once all images have their dates set, you can execute "
                                        "<b>Images->Sort Selected by Date & Time</b> to sort them in the database.</p>"),
+#else
+                                  i18n("<p>Your images/videos are not sorted, which means that navigating using the date bar "
+                                       "will only work suboptimally.</p>"
+                                       "<p>You also don't have EXIF support available, which means that you can't read "
+                                       "image dates from JPEG metadata. It's strongly recommended to recompile KPhotoAlbum "
+                                       "with the <code>exiv2</code> library. After you have done so, you'll be asked what "
+                                       "to do to correct all missing information.</p>"),
+#endif
                                   i18n("Images/Videos Are Not Sorted"),
                                   QString::fromLatin1( "checkWhetherImagesAreSorted" ) );
     }
--- trunk/extragear/graphics/kphotoalbum/XMLDB/FileReader.cpp #698273:698274
@@ -254,15 +254,24 @@
 
     if ( wrongOrder ) {
         KMessageBox::information( MainWindow::Window::theMainWindow(),
+#ifdef HASEXIV2
                                   i18n("<p>Your images/videos are not sorted, which means that navigating using the date bar "
                                        "will only work suboptimally.</p>"
                                        "<p>In the <b>Maintenance</b> menu, you can find <b>Display Images with Incomplete Dates</b> "
                                        "which you can use to find the images that are missing date information.</p>"
                                        "You can then select the images that you have reason to believe have a correct date "
-                                       "in either their EXIF data or on the file, and execute <b>Maintainance->Read EXIF Info</b> "
+                                       "in either their EXIF data or on the file, and execute <b>Maintenance->Read EXIF Info</b> "
                                        "to reread the information.</p>"
                                        "<p>Finally, once all images have their dates set, you can execute "
                                        "<b>Images->Sort Selected by Date & Time</b> to sort them in the database.</p>"),
+#else
+                                  i18n("<p>Your images/videos are not sorted, which means that navigating using the date bar "
+                                       "will only work suboptimally.</p>"
+                                       "<p>You also don't have EXIF support available, which means that you can't read "
+                                       "image dates from JPEG metadata. It's strongly recommended to recompile KPhotoAlbum "
+                                       "with the <code>exiv2</code> library. After you have done so, you'll be asked what "
+                                       "to do to correct all missing information.</p>"),
+#endif
                                   i18n("Images/Videos Are Not Sorted"),
                                   QString::fromLatin1( "checkWhetherImagesAreSorted" ) );
     }