Bug 144347 - pascha (orthodox easter) is not supported in holiday files
Summary: pascha (orthodox easter) is not supported in holiday files
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: FreeBSD Ports FreeBSD
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-17 17:00 UTC by Andriy Gapon
Modified: 2008-01-13 21:21 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Change easter to pascha (3.65 KB, patch)
2008-01-13 21:21 UTC, Dimitris
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Gapon 2007-04-17 17:00:58 UTC
Version:           kdepim-3.5.6 (using KDE KDE 3.5.6)
Installed from:    FreeBSD Ports
Compiler:          gcc version 3.4.6 [FreeBSD] 20060305 amd64
OS:                FreeBSD

This may be a wish rather than a bug, but I am qualifying it this way, because KOrganizer documentation claims to support Pascha keyword:
http://pim.kde.org/components/korganizer/holidays.php

Even more, plan, on which libkholidays is based, supports this keyword and Greek holidays file coming with plan uses Pascha as date for "Holy Pascha".
I believe that using Easter for "Το Άγιον Πάσχα" in holiday_gr is incorrect, but I am not a Greek, so I am not sure.
Comment 1 Allen Winter 2007-04-17 17:31:02 UTC
Yes, it looks like the documentation doesn't match our code.

I don't see that libkholidays supports pascha.

This bug is confirmed.
Comment 2 Allen Winter 2007-04-19 15:52:43 UTC
SVN commit 655833 by winterz:

Support Pascha (Orthodox Easter) in holidays files.
BUGS: 144347

Andriy: it would be very nice if you could add the
necessary pascha entries to all the holidays files
that you think should have it.  Certainly, Ukraine,
Greece, and Russia. Not sure what other countries.



 M  +333 -294  parseholiday.c  
 M  +10 -8     parseholiday.h  
 M  +28 -5     parseholiday.y  
 M  +184 -177  scanholiday.c  
 M  +2 -1      scanholiday.lex  
Comment 3 Andriy Gapon 2007-07-13 17:44:07 UTC
Although this bug is marked as "resolved" I'd like to continue here.

"pascha" now works perfectly with korganizer/libkholidays!
I am pasting a patch for the Ukrainian holidays file. I don't see any mention of "easter" or "pascha" in the Russian file, so it probably doesn't need any updates. I'd let people from other countries to take a look at their files (maybe they need some announcement to be alerted). I see a lot of reference to "easter" in a file for Greece.

--- holiday_ua     Fri Jul 13 18:20:23 2007
+++ holiday_ua     Fri Jul 13 18:20:23 2007
@@ -9,9 +9,9 @@
 small  "Новий Рік" weekend on 1.1
 small  "Різдво Христове" weekend on 7.1
 small  "8 Березня - Міжнародний Жіночий День" weekend on 8.3
-small  "Великдень" weekend on easter
+small  "Великдень" weekend on pascha
 small  "1 Травня - День Праці" weekend on 1.5 length 2 days
 small  "День Перемоги" weekend on 9.5
-small  "Трійця" weekend on easter plus 46 days
+small  "Трійця" weekend on pascha plus 46 days
 small  "День Конституції України" weekend on 28.6
 small  "День Незалежності України" weekend on 24.8
Comment 4 Andriy Gapon 2007-07-13 17:46:44 UTC
Two URLs to check for Easter and Pascha dates:
http://aa.usno.navy.mil/faq/docs/easter.html
http://cgi.duke.edu/~aa63/menologion/paschalion.cgi

BTW, should I reopen this bug to get the changes committed ?
Comment 5 Allen Winter 2007-07-17 14:09:49 UTC
SVN commit 689004 by winterz:

easter -> pascha
CCBUGS: 144347


 M  +2 -2      holiday_ua  


--- branches/KDE/3.5/kdepim/libkholidays/holidays/holiday_ua #689003:689004
@@ -9,9 +9,9 @@
 small	"Новий Рік" weekend on 1.1
 small	"Різдво Христове" weekend on 7.1
 small	"8 Березня - Міжнародний Жіночий День" weekend on 8.3
-small	"Великдень" weekend on easter
+small	"Великдень" weekend on pascha
 small	"1 Травня - День Праці" weekend on 1.5 length 2 days
 small	"День Перемоги" weekend on 9.5
-small	"Трійця" weekend on easter plus 46 days
+small	"Трійця" weekend on pascha plus 46 days
 small	"День Конституції України" weekend on 28.6
 small	"День Незалежності України" weekend on 24.8
Comment 6 Pradeepto K. Bhattacharya 2007-08-06 09:24:49 UTC
SVN commit 696902 by pradeepto:

Merge ...
SVN commit 689004 by winterz:

easter -> pascha
CCBUGS: 144347


 M  +2 -2      holiday_ua  


--- branches/kdepim/enterprise/kdepim/libkholidays/holidays/holiday_ua #696901:696902
@@ -9,9 +9,9 @@
 small	"Новий Рік" weekend on 1.1
 small	"Різдво Христове" weekend on 7.1
 small	"8 Березня - Міжнародний Жіночий День" weekend on 8.3
-small	"Великдень" weekend on easter
+small	"Великдень" weekend on pascha
 small	"1 Травня - День Праці" weekend on 1.5 length 2 days
 small	"День Перемоги" weekend on 9.5
-small	"Трійця" weekend on easter plus 46 days
+small	"Трійця" weekend on pascha plus 46 days
 small	"День Конституції України" weekend on 28.6
 small	"День Незалежності України" weekend on 24.8
Comment 7 Dimitris 2008-01-13 21:21:59 UTC
Created attachment 23011 [details]
Change easter to pascha