Bug 144275 - If there is a & in one of the tags, the /media command won't work
Summary: If there is a & in one of the tags, the /media command won't work
Status: RESOLVED WORKSFORME
Alias: None
Product: kopete
Classification: Applications
Component: Now Listening Plugin (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-15 22:55 UTC by pierre
Modified: 2008-07-17 18:38 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch (565 bytes, patch)
2007-04-15 22:56 UTC, pierre
Details

Note You need to log in before you can comment on or make changes to this bug.
Description pierre 2007-04-15 22:55:10 UTC
Version:           0.12.4 (using KDE 3.5.6, Kubuntu (feisty) 4:3.5.6-0ubuntu14)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.20-15-generic

Hi

I just discovered bug with the /media command (in the nowlistenig plugin) : if there is a & in for instance the artist tag, the command won't work.
Wireshark showed me that a Jabber "packet" was sent with the right <body> but with an empty xhtml document following making the message look empty on XHTML compatible clients...
I wrote a patch I'll attach to this report...
Comment 1 pierre 2007-04-15 22:56:15 UTC
Created attachment 20284 [details]
Patch

This patch fixes the problem by escaping the text before sending it.
Comment 2 Marius Cirsta 2008-07-17 18:23:39 UTC
 This works for me using kdenetwork svn 833475 , I typed in /media and it worked as expected. I did used both the yahoo and jabber protocol though.
 Could you get a more recent version of Kopete from KDE 4 and see if you can still reproduce this bug.
 Also thank you for you work. I'm sorry your patch was ignored but probably no one had the time for it. Anyway I think the problem is now fixed so that's good, if not see if you can make a new patch against a more recent version of Kopete.
Comment 3 pierre 2008-07-17 18:38:07 UTC
I agree, it's fixed in recent Kopete...
No problem with my patch not being applied (well, I didn't even remember when I wrote it...)