Bug 144177 - In Caption/Tags sidebar, new Tags inherit the image of their parents
Summary: In Caption/Tags sidebar, new Tags inherit the image of their parents
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Captions (show other bugs)
Version: 4.1.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-13 14:56 UTC by Dotan Cohen
Modified: 2021-01-19 17:21 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.2.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2007-04-13 14:56:52 UTC
Version:            (using KDE KDE 3.5.6)
Installed from:    Fedora RPMs
OS:                Linux

When creating new tags in the Comments/Tags sidebar, the new tag inherits the image of it's parent tag. I would expect the new tag to have no image, just like new tags created in other parts of Digikam have no image.
Comment 1 Andi Clemens 2008-08-16 15:47:48 UTC
Yes, I think this should be improved... I can confirm this, too.
Comment 2 Andi Clemens 2009-10-08 01:05:18 UTC
I also would prefer an empty icon, but there might also be users who want to have the icon of the parent set for the child tag.

We need to discuss this. Any suggestions here?
Comment 3 Dotan Cohen 2009-10-13 15:17:07 UTC
> We need to discuss this. Any suggestions here?

An option. It could either be a general option for all of digikam, or a checkbox for each tag whether or not new child tabs get an empty icon or their parent's icon.
Comment 4 caulier.gilles 2011-12-16 12:27:03 UTC
Dotan,

This file still valid using digiKam 2.4 ?

Gilles Caulier
Comment 5 Dotan Cohen 2011-12-17 18:40:08 UTC
‏Yes, still valid.

Steps to reproduce:
1) Assign an an icon/image to a tag.
2) Right-click the tag, select New Tag.
3) Finish creating the new tag, do not assign an image.

Notice that the icon/image of the new tag is the icon/image of the parent tag.
Comment 6 caulier.gilles 2014-09-02 10:03:17 UTC
Dotan,

This file still valid using last digiKam 4.2.0 ?

Gilles Caulier
Comment 7 Dotan Cohen 2014-09-02 18:16:57 UTC
The issue is still valid in Digikam 4.1, using the steps to reproduce from Comment #5.
Comment 8 caulier.gilles 2016-07-06 13:59:34 UTC
This problem still valid using last digiKam 5.0.0 ?

Gilles Caulier
Comment 9 caulier.gilles 2016-12-01 10:08:20 UTC
Any feedback with current AppImage bundle for Linux ?

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier
Comment 10 Barbara Scheffner 2016-12-01 11:58:45 UTC
I support the proposal of Dotan Cohen to have an option whether the new tag should inherit the icon or not, because the first can save you the hassle of finding a particular tag in lenghty tables/lists. I even "abuse" this function if I want the same icon for a tag that is not a child. I first create the new tag as a child and then move it to somewhere eles in the tree.
Comment 11 David Haslam 2021-01-19 10:47:42 UTC
I think there may be a simple fix for this, that might allow us to
close this very old report.

At the moment, if the user wishes to use the standard icon, the tag
has to be first created with right click then 'New Tag'. Then right
click on the new tag then either 'Reset Tag Icon', or 'Properties'
then 'Reset'.

If we put a Reset button on the 'New Tag' popup dialog, then the user
may choose the standard icon at creation time saving a few clicks.

The 'New Tag' popup and the 'Properties' popup share the same dialog
code (core/libs/tags/widgets/tageditdlg.cpp), so it is a simple fix to
remove the code that disables the button.

I'll send a merge request shortly.
Comment 12 Maik Qualmann 2021-01-19 17:21:01 UTC
Fixed with this commit:

https://invent.kde.org/graphics/digikam/-/commit/087bdcd4c244e5acd5552c8b08e8636dc92ca31f

Maik