Bug 144050 - Up/Down arrows in Plot Content skip too many
Summary: Up/Down arrows in Plot Content skip too many
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-11 00:06 UTC by D. V. Wiebe
Modified: 2007-04-12 19:56 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Proposed patch (1.17 KB, patch)
2007-04-11 20:45 UTC, Andrew Walker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description D. V. Wiebe 2007-04-11 00:06:53 UTC
Version:           1.4.0_svn_647607 (using KDE KDE 3.5.6)
Installed from:    Compiled From Sources
Compiler:          gcc (GCC) 4.1.2 
OS:                Linux

The Up and Down arrow buttons in the Content tab of the Edut Plot dialog move selected curve(s) up or down two slots instead of one, as expected.

Steps to reproduce:

1. Plot many curves, say: C1, C2, C3, C4, C5
2. Edit Plot -> Content
3. Select one curve, say, C4 and move it, say, up.

Results:

  The resulting order will be:   C1, C4, C2, C3, C5 (ie. C4 moved up two slots)

Expected results:

  The resulting order should be: C1, C2, C4, C3, C5 (ie. C4 moves up one slot)
Comment 1 Andrew Walker 2007-04-11 20:45:46 UTC
Created attachment 20235 [details]
Proposed patch

Patch removes duplicate connections.
Comment 2 Adam Treat 2007-04-12 18:02:40 UTC
Interesting.  These duplicate connections date back to when the file was created.  Looks like they should go.
Comment 3 Andrew Walker 2007-04-12 19:56:23 UTC
SVN commit 653138 by arwalker:

BUG:144050 Remove duplicate connections so dialog functions correctly

 M  +0 -11     view2dplotwidget.ui.h  


--- branches/work/kst/1.5/kst/src/libkstapp/view2dplotwidget.ui.h #653137:653138
@@ -30,17 +30,6 @@
 
     _plot = 0L;
 
-    connect(DisplayedCurveList, SIGNAL(clicked(QListBoxItem*)), this, SLOT(updateButtons()));
-    connect(AvailableCurveList, SIGNAL(clicked(QListBoxItem*)), this, SLOT(updateButtons()));
-    connect(DisplayedCurveList, SIGNAL(doubleClicked(QListBoxItem*)), this, SLOT(removeDisplayedCurve()));
-    connect(AvailableCurveList, SIGNAL(doubleClicked(QListBoxItem*)), this, SLOT(addDisplayedCurve()));
-    connect(DisplayedCurveList, SIGNAL(selectionChanged()), this, SLOT(updateButtons()));
-    connect(AvailableCurveList, SIGNAL(selectionChanged()), this, SLOT(updateButtons()));
-    connect(_remove, SIGNAL(clicked()), this, SLOT(removeDisplayedCurve()));
-    connect(_add, SIGNAL(clicked()), this, SLOT(addDisplayedCurve()));
-    connect(_up, SIGNAL(clicked()), DisplayedCurveList, SLOT(up()));
-    connect(_down, SIGNAL(clicked()), DisplayedCurveList, SLOT(down()));
-
     _up->setPixmap(BarIcon("up"));
     _up->setEnabled(false);
     _up->setAccel(ALT+Key_Up);