Bug 144027 - websvn.kde.org shows fonts in courier though fixed font has been set to something else
Summary: websvn.kde.org shows fonts in courier though fixed font has been set to somet...
Status: RESOLVED FIXED
Alias: None
Product: www.kde.org
Classification: Websites
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: kde-www mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-10 10:35 UTC by peppelorum
Modified: 2007-05-28 21:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
A patch for kde.css (83 bytes, patch)
2007-05-23 10:37 UTC, peppelorum
Details

Note You need to log in before you can comment on or make changes to this bug.
Description peppelorum 2007-04-10 10:35:53 UTC
Version:            (using KDE KDE 3.5.5)
Installed from:    Debian testing/unstable Packages

One of the new style sheets for kde.org and websvn.kde.org (http://websvn.kde.org/docroot/kde.css) sets a specific font for the pre-tag. The first entries at row 81 are "courier" and "courier new". This hinders users that uses Konqueror and wants pre/fixed/monospace fonts to be in some special font (as found in Settings->Configure Konqueror->Fonts). So the pre-tag is now shown with courier regardless what font you have set for fixed texts.
It would be much better if "monospace" or similar was first in the list so the font substituion worked as planned, or even better, don't specify font at all and leave that to the browser.

Cheers!
Peppe
Comment 1 peppelorum 2007-05-23 10:37:31 UTC
Created attachment 20675 [details]
A patch for kde.css

Bare with me, this is my first patch so don't go bananas if something is
wrong;-)

This is a simple patch to totally remove the font-family for the pre tag in
kde.css to fix this "bug" since it probably not is necessary since many (if not
all) visual user agents already displays pre tags with a fixed font.
Comment 2 Sebastian Kügler 2007-05-23 13:59:52 UTC
On Wednesday 23 May 2007 10:37:32 peppelorum wrote:
[bugs.kde.org quoted mail]

Olaf, can you approve this? (Not sure if it's in line with the accessibility 
you worked on.) If you ACK it, I'm happy to commit.
Comment 3 Olaf Jan Schmidt 2007-05-23 15:18:38 UTC
Yes, this change is fine for me.

Olaf
Comment 4 Sebastian Kügler 2007-05-24 10:45:49 UTC
On Wednesday 23 May 2007 15:18:40 Olaf Jan Schmidt wrote:
[bugs.kde.org quoted mail]

Thanks for having a look, Olaf.

Now if anyone can tell me where in SVN the file resides, I can commit :-)
Comment 5 Dirk Mueller 2007-05-28 21:16:35 UTC
SVN commit 669205 by mueller:

remove hardcoded font-family
BUG: 144027


 M  +0 -1      css.php  


--- trunk/www/media/css.php #669204:669205
@@ -109,7 +109,6 @@
     margin: 0.3em;
     padding: 0.3em;
     font-size: 1em;
-    font-family: Courier, 'Courier New', 'Andale Mono', Monaco, monospace;
     <?php color ( $black )?>
     <?php background ( $grey_f )?>
     <?php border( $blue_grey, 'dashed' )?>