Version: HEAD (using KDE KDE 3.5.1) OS: Linux PROBLEM: The File... Save Data menu item appears to have no effect when selected It should at least toggle its checkmark to show that the user has taken some action. If, on the other hand, it really does nothing then it should be removed.
The "Save Data" option causes the data to be saved in the kst file, when a kst file is saved. Ideally this would actually be a checkbox in the save dialog, not in the menu... the following patch will make the check box work, but the feature's UI is still marginal.. Index: kst.cpp =================================================================== --- kst.cpp (revision 650125) +++ kst.cpp (working copy) @@ -420,8 +420,9 @@ connect(PauseAction, SIGNAL(toggled(bool)), this, SLOT(updatePausedState(bool))); /************/ - _saveData = new KToggleAction(i18n("Save Da&ta"),"save_vector_data", 0, - actionCollection(), "save_vector_data"); + //_saveData = new KToggleAction(i18n("Save Da&ta"),"save_vector_data", 0, + _saveData = new KToggleAction(i18n("Save Da&ta"), 0,0,0,0, + actionCollection(), "save_vector_data"); _saveData->setToolTip(i18n("Save Vector Data To Disk")); _saveData->setWhatsThis(i18n("When selected, data in vectors will be saved into the Kst file."));
It looks like better than nothing for this the 1.4 release.
SVN commit 650986 by netterfield: saveData uses a check box, not an icon. Reviewed by Andrew CCBUG: 143857 M +2 -2 kst.cpp --- trunk/extragear/graphics/kst/src/libkstapp/kst.cpp #650985:650986 @@ -420,8 +420,8 @@ connect(PauseAction, SIGNAL(toggled(bool)), this, SLOT(updatePausedState(bool))); /************/ - _saveData = new KToggleAction(i18n("Save Da&ta"),"save_vector_data", 0, - actionCollection(), "save_vector_data"); + _saveData = new KToggleAction(i18n("Save Da&ta"), 0,0,0,0, + actionCollection(), "save_vector_data"); _saveData->setToolTip(i18n("Save Vector Data To Disk")); _saveData->setWhatsThis(i18n("When selected, data in vectors will be saved into the Kst file."));
If the user opens an existing Kst file (or does a Save As... on a new session) when they re-save they will not be presented with a save dialog as the filename is already known. Is it safe to assume they always want to keep the same saveData option? Or can we just tell them to do a Save As... if they want to change it? In the former case is there a way of knowing how the file was originally saved?
good point. Maybe this feature belongs with the vectors rather than with save?
So should we add a checkbox to the vector dialog that allows the user to set this on a per vector basis? Presumbably this would apply only to vectors read from file (generated vectors can recreate their data).
Original bug report has been addressed. Another bug report should be submitted if the UI for the functionality is not adequate.