Bug 143549 - [PATCH] Chat History: When searching for "time" or "in", no filtering occurs
Summary: [PATCH] Chat History: When searching for "time" or "in", no filtering occurs
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: History Plugin (show other bugs)
Version: 0.12.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-28 16:03 UTC by Johannes Jowereit
Modified: 2010-07-06 18:01 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jowereit 2007-03-28 16:03:50 UTC
Version:           0.12.3 (using KDE KDE 3.5.5)
Installed from:    SuSE RPMs

When typing "time" or "in" into the search box at the bottom of the chat history dialog, the list is not filtered, but all messages appear.

The reason for this is obviously that the search is done in the whole XML log file, including the tags and attributes.
Comment 1 Simon80 2007-10-23 07:52:11 UTC
I've attached a patch to Bug 148659 that should fix this issue.
Comment 2 George Kiagiadakis 2008-07-23 16:40:46 UTC
I can confirm that this still happens in kopete 0.50.80 from KDE 4.0.99 and applies to all the words that are included in the xml file including "time", "in", "from", "nick", "msg", "=", my account address, "<msg", "</msg>" and anything else xml-related that exists in every dialog.
Comment 3 Rémy Greinhofer 2009-12-22 17:30:25 UTC
If I input "time", "from" or "nick" in the search text field I have no problem. 

However, if I input "in" I get this:
in-top:12px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">Hey! How are you doing?

And if I input "to", I get this:
top:12px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">hi

which should not happen.

Therefore, there is still a but in Kopete 0.80.2 (KDE SC 4.3.4).
Comment 4 Roman Jarosz 2010-07-06 18:01:49 UTC
Fixed at least in KDE SC 4.5