Bug 143511 - korganizer doesn't save resources immediately when changed or deleted
Summary: korganizer doesn't save resources immediately when changed or deleted
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-27 13:44 UTC by Jason 'vanRijn' Kasper
Modified: 2007-04-04 16:41 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jason 'vanRijn' Kasper 2007-03-27 13:44:28 UTC 
Version:            (using KDE KDE 3.5.6)
Installed from:    Fedora RPMs
OS:                Linux

Although korganizer saves new events to the calendar file immediately, it does not save the file when events are deleted or changed, it appears.  This is causing perceived data reliability problems for kpilot.

Steps to reproduce:

1) add new event called "testing" to korganizer calendar (using the standard local .ics file ~/.kde/share/apps/korganizer/std.ics)
2) click "ok" to close the modal dialog
3) observe calendar event shows in korganizer correctly
4) touch ~/.kde/share/apps/korganizer/std.ics
5) observe korg blink and retain the new data

6) double-click on "testing" added at #1
7) change name to "testingblah"
8) click "ok" to close modal dialog
9) observe calendar event shows in korganizer correctly
10) touch ~/.kde/share/apps/korganizer/std.ics
11) observe korg blink and lose the change in name

12) select "testing" event added in #1
13) hit "delete"
14) observe calendar event correctly goes away in korganizer
15) touch ~/.kde/share/apps/korganizer/std.ics
16) observe korg blink and "testing" event show up again
Comment 1 Jason 'vanRijn' Kasper 2007-04-04 16:32:58 UTC 
SVN commit 650424 by vanrijn:

- adding setSavePolicy( SaveDelayed ); to resourcelocal/resourcelocaldir
  per reinhold to address bug 143511

CCBUGS:143511


 M  +2 -0      branches/work/kdepim-3.5.5+/libkcal/resourcelocal.cpp  
 M  +2 -0      branches/work/kdepim-3.5.5+/libkcal/resourcelocaldir.cpp  


--- branches/work/kdepim-3.5.5+/libkcal/resourcelocal.cpp #650423:650424
@@ -109,6 +109,8 @@
 
   setType( "file" );
 
+  setSavePolicy( SaveDelayed );
+
   connect( &mDirWatch, SIGNAL( dirty( const QString & ) ),
            SLOT( reload() ) );
   connect( &mDirWatch, SIGNAL( created( const QString & ) ),
--- branches/work/kdepim-3.5.5+/libkcal/resourcelocaldir.cpp #650423:650424
@@ -89,6 +89,8 @@
 {
   setType( "dir" );
 
+  setSavePolicy( SaveDelayed );
+
   connect( &mDirWatch, SIGNAL( dirty( const QString & ) ),
            SLOT( reload( const QString & ) ) );
   connect( &mDirWatch, SIGNAL( created( const QString & ) ),
Comment 2 Jason 'vanRijn' Kasper 2007-04-04 16:41:56 UTC 
SVN commit 650427 by vanrijn:

- adding setSavePolicy( SaveDelayed ); to resourcelocal/resourcelocaldir
  per reinhold to address data loss bug 143511 

BUGS:143511


 M  +2 -0      resourcelocal.cpp  
 M  +2 -0      resourcelocaldir.cpp  


--- branches/KDE/3.5/kdepim/libkcal/resourcelocal.cpp #650426:650427
@@ -109,6 +109,8 @@
 
   setType( "file" );
 
+  setSavePolicy( SaveDelayed );
+
   connect( &mDirWatch, SIGNAL( dirty( const QString & ) ),
            SLOT( reload() ) );
   connect( &mDirWatch, SIGNAL( created( const QString & ) ),
--- branches/KDE/3.5/kdepim/libkcal/resourcelocaldir.cpp #650426:650427
@@ -89,6 +89,8 @@
 {
   setType( "dir" );
 
+  setSavePolicy( SaveDelayed );
+
   connect( &mDirWatch, SIGNAL( dirty( const QString & ) ),
            SLOT( reload( const QString & ) ) );
   connect( &mDirWatch, SIGNAL( created( const QString & ) ),