Version: (using KDE KDE 3.5.6) Installed from: Slackware Packages Konqueror has had an the adblock functionality for some time now. oviously having that extension alone doesn't help a lot, one needs a filterset. On Sat Sep 17, 2005 11:46 am ( a long time ago ) "G" offered here: http://www.filtersetg.com/forum/viewtopic.php?p=654&highlight=konqueror#654 his help in the development of an autoupdater of his filterset. such an extension would be great! i once heard, that advertising corporations could sue kde, if it was enabled by default, so maybe an integration into kdeaddons/having it not enabled by default would be more feasible?
There is this service from adblockplus now: http://adblockplus.org/en/subscriptions Would be really nice, if this would find its way in Konqui of KDE 4
I second this request. Right now, I update (too infrequently) this filterset by hand.
Implementing something like AdblockPlus would be very interesting. See the source code here : http://adblockplus.org/en/source
*** Bug 165129 has been marked as a duplicate of this bug. ***
*** This bug has been confirmed by popular vote. ***
*** Bug 201715 has been marked as a duplicate of this bug. ***
I created a patch for KDE 4.2.4 which integrates into KHTML's khtml_settings.cpp to fetch and load filter lists from easylist.adblockplus.org. To load the lists, add the following lines to your khtmlrc in section "Filter Settings" (these lines are just examples, but you will get the idea): AdblockPlusMaxAgeDays=5 AdblockPlusName-1=EasyList AdblockPlusLocalFilename-1=adp-easylist.txt AdblockPlusURL-1=http://easylist.adblockplus.org/easylist.txt AdblockPlusName-2=EasyPrivacy AdblockPlusLocalFilename-2=adp-easyprivacy.txt AdblockPlusURL-2=http://easylist.adblockplus.org/easyprivacy.txt The patch will take care of downloading these lists (if cached files do not exist or too old) and integrate patterns into KHTML's AdBlock list. The user-defined list will not be touched or modified. The patch contains no UI code yet and is basically a proof-of-concept. Issues among others is the cache location ("/tmp/"). Feedback is welcome.
Created attachment 35759 [details] Download filter lists from adblockplus.org This patch applies to KDE 4.2.4's khtml_settings.cpp No GUI code contained.
Thomas, that's great! May I suggest, in the interests of neutrality of use, trademarks, overactive lawyers that you change all references from AdblockPlus to something neutral such as "HTMLFilterList". Let's let the users determine what the HTML filter will be used for.
Created attachment 35762 [details] Updated patch to download filter lists from adblockplus.org Updated patch: Removed use of "AdblockPlus" term, using "HTMLFilterList" instead; filter lists can be enabled/disabled with "HTMLFilterListEnabled" (maybe necessary for future GUI); skipping more unused lines from filter list; using KGlobal/KStandardDirs to determine cache directory (not clean, though); minor refactoring
Created attachment 35776 [details] Enhances Konqueror's settings GUI to configure automatic filter lists This patch modifies Konqueror's filteropts.(cpp|h) to add GUI to enable/disable preconfigured filter lists and to change the automatic update interval. Filter lists must be preconfigure in either the system-wide or personal khtmlrc. Currently, new filter lists can not be added using the GUI, and neither can existing ones be edited; this is a GUI feature only, as the configuration load/save functions would support that. Feedback is welcome...
Created attachment 35777 [details] Fixes minor issue with previous patch
Created attachment 35778 [details] Example khtmlrc Example khtmlrc with preconfigured filter lists from http://easylist.adblockplus.org/
Created attachment 37175 [details] Patch for kdebase-4.3.1 Updated patch for KDElibs 4.3.1. No functional changes.
Created attachment 37176 [details] Patch for kdelibs-4.3.1 Updated patch for KDElibs 4.3.1. No functional changes.
For kde-4.3.2 the same patch
Why the hell this patch isn't merged in upstream?
(In reply to comment #17) > Why the hell this patch isn't merged in upstream? This patch is currently under review: http://reviewboard.kde.org/r/2265/
(In reply to comment #18) > This patch is currently under review: > http://reviewboard.kde.org/r/2265/ I perfectly know that it's how I've come across this bug report. I just wonder why it takes so long to be accepted - once being the most advanced browser Konqueror now became a trail horse - it has the least features and the most bugs. I'd even say that Konqueror in it's current state is unusable - it crashes far too often, it has no features required for productive work, it has bugs which makes it very hard to use.
Hell yes! Get this into the next update as quickly as possible - sooner even. This one single improvement to Konqueror will greatly enhance it's value to users.
SVN commit 1096606 by dfaure: Finally commit the patch by Thomas Fischer which implements FEATURE: Automatic AdBlock filter list updates GUI: the automatic adblock filters must be enabled in "Configure Konqueror / AdBlocK Filters" Compared to the patch r6, I replaced the manual copy() method with a base class KHTMLSettingsData which contains all the settings, so that they can be copied in one line. FEATURE: 143495 Fixed for: 4.5 M +173 -4 kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp M +48 -0 kdebase/apps/konqueror/settings/konqhtml/filteropts.h M +2 -0 kdelibs/khtml/CMakeLists.txt M +127 -4 kdelibs/khtml/khtml_settings.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1096606
I have activate the new automatic filterset and add the same filter like in firefox or chromium, but the google advertising on the right side on google.de or google.com are no longer blocked in Konqueror. I use Kubuntu 10.10 64, KDE 4.5.1.