Bug 143488 - FTP ioslave unnecessarily asks for password
Summary: FTP ioslave unnecessarily asks for password
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Frameworks and Libraries
Component: ftp (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
: 146130 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-03-26 16:12 UTC by David Anderson
Modified: 2011-04-28 15:48 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.7


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Anderson 2007-03-26 16:12:48 UTC
Version:            (using KDE KDE 3.5.6)
Installed from:    Fedora RPMs

When visiting an FTP site for which there is an entry in kwallet, the user gets two dialogues:

1) kwallet password dialogue
2) filled-in FTP password dialogue

The latter is unnecessary. kio_fish doesn't do it - it just goes ahead and tries the kwallet password. A password should only be requested from the user if the kwallet one doesn't work. It's just an unnecessary click. If the user has saved a password in kwallet for that username, he wants it to be used.

So the problems here are two:
1) Inconsistent with other kioslaves
2) Usability: unnecessary click to confirm
Comment 1 Mike Williams 2009-06-06 22:09:54 UTC
*** Bug 146130 has been marked as a duplicate of this bug. ***
Comment 2 Matthijs 2009-08-26 13:43:15 UTC
I confirm this using KDE 4.3
Comment 3 Martin Sandsmark 2009-08-26 16:41:34 UTC
I thought it was on purpose, so you could choose which user to log in as. 

And also a security feature, so that random applications can't read all your remote shares.
Comment 4 Matthijs 2009-08-26 16:46:34 UTC
Then you could use the user@ftp-site syntax.

And concerning the security, you still have to give an application permission to use the wallet right? Or doesn't that work that way using kioslaves?
Comment 5 Martin Sandsmark 2009-08-26 16:53:48 UTC
I tried deleting the whole ACL for kwallet, but I still don't get a popup asking if anything should get access to the kwallet when entering the FTP url.
Comment 6 Javier 2009-09-01 12:55:40 UTC
*** This bug has been confirmed by popular vote. ***
Comment 7 Matthijs 2009-09-01 17:36:04 UTC
A solution is asking the user if anyone will be allowed to access the kioslave, so that the password is remembered AND the user never gets asked for it again.
Comment 8 Dawit Alemayehu 2011-04-28 15:48:51 UTC
Git commit 3ab6c7f05f113353435e10b6d6fd0fdbbd495855 by Dawit Alemayehu.
Committed on 22/04/2011 at 03:40.
Pushed by adawit into branch 'master'.

Fixed most of the issue related to login.

BUG: 258888
BUG: 99686
BUG: 143488
BUG: 124675

FIXED-IN: 4.7
REVIEW: 101173

M  +83   -33   kioslave/ftp/ftp.cpp     
M  +3    -1    kioslave/ftp/ftp.h     

http://commits.kde.org/kdelibs/3ab6c7f05f113353435e10b6d6fd0fdbbd495855