Bug 143247 - Record parent todo's when recording completed todo to journal.
Summary: Record parent todo's when recording completed todo to journal.
Status: REPORTED
Alias: None
Product: korganizer
Classification: Applications
Component: todoview (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 144927 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-03-20 04:26 UTC by Jesse Merriman
Modified: 2020-10-29 02:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch against calendarview.h from 3.3.5 (273 bytes, patch)
2007-03-20 04:41 UTC, Jesse Merriman
Details
Patch against calendarview.cpp from 3.3.5 (1.49 KB, patch)
2007-03-20 04:43 UTC, Jesse Merriman
Details
UNTESTED patch against trunk's calendarview.h (273 bytes, patch)
2007-03-20 04:45 UTC, Jesse Merriman
Details
UNTESTED patch against trunk's calendarview.cpp (1.48 KB, patch)
2007-03-20 04:47 UTC, Jesse Merriman
Details
Nicer patch against calendarview.cpp from trunk (1.48 KB, patch)
2007-03-20 06:12 UTC, Jesse Merriman
Details
Nicer patch against calendarview.cpp from 3.3.5 (1.52 KB, patch)
2007-03-20 06:14 UTC, Jesse Merriman
Details
Even nicer patch against calendarview.cpp from 3.3.5 (1.49 KB, patch)
2007-03-20 06:25 UTC, Jesse Merriman
Details
Hopefully last version of patch against calendarview.cpp 3.3.5 (1.49 KB, patch)
2007-03-20 06:29 UTC, Jesse Merriman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Merriman 2007-03-20 04:26:38 UTC
Version:           3.5.5 (using KDE KDE 3.5.5)
Installed from:    Gentoo Packages
OS:                Linux

When a completed todo is set to automatically add a journal entry, only that todo's summary is recorded. Often this doesn't give me enough information, and I need to know its parents to fully identify it, especially in cases where different parent-todos each have identically-named children, as so:

Foo
 +- x
Bar
 +- x

Right now, completing Foo/x would result in this journal entry:

To-do completed: x (08:46 pm)

This does not tell me whether it refers to Foo/x or Bar/x. I propose that it should show the complete hierarchy, like this:

To-do completed at 08:46 pm:
  Foo
    x

I've written a patch that does just that.

PS: this is similar to bug 81910.
Comment 1 Jesse Merriman 2007-03-20 04:41:23 UTC
Created attachment 20046 [details]
Patch against calendarview.h from 3.3.5
Comment 2 Jesse Merriman 2007-03-20 04:43:10 UTC
Created attachment 20047 [details]
Patch against calendarview.cpp from 3.3.5

I've tested this and the calendarview.h 3.3.5 patch.
Comment 3 Jesse Merriman 2007-03-20 04:45:55 UTC
Created attachment 20048 [details]
UNTESTED patch against trunk's calendarview.h

Untested patch against revision 627512 of calendarview.h
Sorry its untested, but I figure it might be helpful and is better than
nothing.
Comment 4 Jesse Merriman 2007-03-20 04:47:09 UTC
Created attachment 20049 [details]
UNTESTED patch against trunk's calendarview.cpp

Untested patch against revision 640714 of calendarview.cpp
See my comment from the previous patch..
Comment 5 Jesse Merriman 2007-03-20 04:58:56 UTC
I've been testing only with 3.3.5, since I happened to have a source tarball for that at hand. The trunk patches I posted are just copy-paste jobs that were not tested. I have done very little KDE or QT coding, so be extra-critical of this code. Particularly I am unsure if the internationalization is OK (eg right-to-left languages and the indentation,...).
Comment 6 Jesse Merriman 2007-03-20 06:12:28 UTC
Created attachment 20050 [details]
Nicer patch against calendarview.cpp from trunk

Ack, the first version of this patch was producing excess newlines. This fixes
that.
Comment 7 Jesse Merriman 2007-03-20 06:14:57 UTC
Created attachment 20051 [details]
Nicer patch against calendarview.cpp from 3.3.5

Again, removes an excess newline.
Comment 8 Jesse Merriman 2007-03-20 06:25:56 UTC
Created attachment 20052 [details]
Even nicer patch against calendarview.cpp from 3.3.5

Fixes one small code screw-up in the previous version of this patch.
Comment 9 Jesse Merriman 2007-03-20 06:29:52 UTC
Created attachment 20053 [details]
Hopefully last version of patch against calendarview.cpp 3.3.5

Dammit. I should not be doing this while so tired.. Anyway, the previous
version of this patch was in the wrong order (new->old), here is how it should
be. I won't be submitting any more tonight, I promise.
Comment 10 gjditchfield 2020-10-29 02:46:52 UTC
*** Bug 144927 has been marked as a duplicate of this bug. ***