Bug 142699 - New symbol type is desirable
Summary: New symbol type is desirable
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-08 20:32 UTC by Andrew Walker
Modified: 2007-03-08 21:30 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Proposed patch (779 bytes, patch)
2007-03-08 20:37 UTC, Andrew Walker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Walker 2007-03-08 20:32:49 UTC
Version:           HEAD (using KDE KDE 3.5.1)
Installed from:    Compiled From Sources
OS:                Linux

The LFI team would like to see a new symbol type for data points that is a simple point of 1 pixel in size.

This is useful when displaying large amounts of data where the x-axis is not monotonically increasing.
Comment 1 Andrew Walker 2007-03-08 20:37:02 UTC
Created attachment 19913 [details]
Proposed patch
Comment 2 Netterfield 2007-03-08 20:51:28 UTC
Seems ok.  Should it respect line width or something like that?


On Thursday 08 March 2007 2:37:03 pm Andrew Walker wrote:
[bugs.kde.org quoted mail]
Comment 3 Andrew Walker 2007-03-08 21:30:24 UTC
SVN commit 640694 by arwalker:

BUG:142699 Add point to symbol type where the point size respects the line width.

 M  +8 -0      kstcurvepointsymbol.cpp  
 M  +1 -1      kstcurvepointsymbol.h  


--- trunk/extragear/graphics/kst/src/libkstmath/kstcurvepointsymbol.cpp #640693:640694
@@ -128,6 +128,14 @@
         p->drawPolygon(pts);
       }
       break;
+    case 13:
+      if (s < 4) {
+        p->drawPoint(x,y);
+      } else {
+        p->setBrush(QBrush::SolidPattern);
+        p->drawPie(x-(s/4), y-(s/4), s/2, s/2, 0, 5760);
+      }
+      break;
   }
 
   p->setBrush(QBrush::NoBrush);
--- trunk/extragear/graphics/kst/src/libkstmath/kstcurvepointsymbol.h #640693:640694
@@ -21,7 +21,7 @@
 #include "kst_export.h"
 #include <qpainter.h>
 
-#define KSTPOINT_MAXTYPE 13
+#define KSTPOINT_MAXTYPE 14
 
 namespace  KstCurvePointSymbol {
     /** draw the point on a painter the scale of the point is based on size */