Bug 141760 - please change default logs path
Summary: please change default logs path
Status: RESOLVED LATER
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: 1.0.1
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-15 23:25 UTC by Philippe Cloutier
Modified: 2010-11-15 17:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Cloutier 2007-02-15 23:25:08 UTC
Version:           1.0.1 (using KDE KDE 3.5.6)
Installed from:    Debian testing/unstable Packages
OS:                Linux

In r478035, the default path for logs was changed to ~/logs/, from ~ according to the commit message. Changing from ~ was definitely a good idea, but I'm afraid that storing in ~ was a bug and that r478035 fixed it with something I still consider a regression from storing logs in ~/.kde/share/apps/konversation. I would like the default path to be changed back to that. However, if you disagree, please change it to something less vague than ~/logs/ anyway.
Comment 1 Eike Hein 2007-02-16 00:31:41 UTC
The path probably got changed during the transition to the KConfigXT preferences storage framework, when basically all of the preferences-related code got rewritten. You're going to have to do a better job articulating why you think ~/logs is a regression, though - I think it's definitely a step up from the old path deeply buried into a hidden directory hierarchy, and there haven't been any complaints up until now. I'm assuming you feel the directory name is too generic?

Also, should we decide to change the path, we're going to have to be careful about how we go about it, and if we can do it at all. Other applications may work on the assumption that Konversation uses that particular directory for log storage; the recently added Konversation backend to Beagle comes to mind. Someone would have to look into whether that thing is smart enough to peek at Konversation's preferences file to determine the storage location, and whether there are other apps that make assumptions about Konversation's log dir path.

If such complications do arise, I'd vote for not changing the path until they're resolved, or until we're switching to KDE4 when everybody should reasonably expect breakages and incompatible changes.

I encourage other Konvi devs to speak up on this matter ...
Comment 2 Philippe Cloutier 2007-02-17 00:43:21 UTC
You're right. The directory name is too generic (this is what I meant by "vague"). One reason which is by itself almost good enough to revert to the previous default is consistency.

As for being careful, I don't think there should be issues. I don't know Beagle, but if its konversation support is appropriate, it should already support the previous path. In general, there is no need for more care than when the path was first changed.
Comment 3 Eike Hein 2007-02-17 03:38:52 UTC
The previous default path isn't really an option from my POV, it sucks far too much - something like ~/Konversation Logs would be OK, but I'm opposed to changing this prior to the onset of the KDE 4 era for compatibility reasons. The implications for third-party apps for one, but also the implications for users: With the way KConfigXT works, if we change the default path and a user never touched that particular setting, they'll get hit by the change automatically and Konvi will start logging in the other dir, causing confusion and disruption (and yes, I would have been opposed to the last change for the same reason, but I wasn't sitting at the table at the time and it happened, and now it's in 1.0, which is a commitment) unless additional code is written to survey the old dir and copy over its contents. Something for which I don't see any volunteers yet.


> I don't know Beagle, but if its konversation support is appropriate, it should already support the previous path.

The last three public releases of Konversation have used ~/logs, most notably the 1.0 release, but generally all reasonably mature releases of the application. Beagle's Konvi support is recent, and it's no stretch to assume that others have taken note of the 1.0 release as well. That said, I still haven't had time to look at what Beagle is actually doing.


> In general, there is no need for more care than when the path was first changed. 

I strongly disagree and generally vote against changing this for the remaining KDE 3.x releases. We can see about the KDE4 port.
Comment 4 Philippe Cloutier 2007-02-17 08:42:18 UTC
> With the way KConfigXT works, if we change the default path and a user never touched that particular setting, they'll get hit by the change automatically and Konvi will start logging in the other dir, causing confusion and disruption
In this case, this is a bug which will affect upgrades from distributions such as Debian stable.

> I strongly disagree and generally vote against changing this for the remaining KDE 3.x releases.
Why do you disagree strongly? As you mentioned, "there haven't been any complaints up until now", so I would expect no complaints for changing back neither.
Comment 5 Eike Hein 2007-02-17 13:25:46 UTC
> In this case, this is a bug which will affect upgrades from distributions such as Debian stable. 

Which is unfortunate, but no good justification to do it again any time soon, and Debian stable is shipping a pre-1.0 release. We have changed other APIs pre-1.0 as well, e.g. the DCOP interface. We commit to predictable upgrade behavior post-1.0. 


> Why do you disagree strongly?

I suggest reading my prior posts, which explain this quite thoroughly.
Comment 6 Philippe Cloutier 2007-02-17 19:52:08 UTC
> Which is unfortunate, but no good justification to do it again any time soon, and Debian stable is shipping a pre-1.0 release.
OK. I opened #141837 about this problem.


> I suggest reading my prior posts, which explain this quite thoroughly.
I already red your prior posts. I'm sorry but I can't see how they would explain a strong disagreement.
Comment 7 Stefan Monov 2007-02-21 01:15:10 UTC
I agree with the reporter, the deeply buried dir was better than ~/logs as this clutters the homedir unneededly - Konversation has the option in Window ยป Open Logfile for #channel.