Bug 141555 - Delete empty folder after deleting files
Summary: Delete empty folder after deleting files
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Collections/Local (show other bugs)
Version: 2.0-SVN
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-11 21:20 UTC by Iñaki Baz Castillo
Modified: 2009-12-09 11:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Iñaki Baz Castillo 2007-02-11 21:20:59 UTC
Version:           1.4.5 (using KDE 3.5.6, Kubuntu (edgy) 4:3.5.6-0ubuntu1~edgy1)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17-10-386

If I delete all the songs of an album and the folder where thery were becomes empty Amarok should delete it.

Of course this should be very carefully and not delete the parent folder if it is a collection base dir.
Comment 1 Christian González 2007-03-30 01:02:42 UTC
Agree with that.
And Amarok should delete empty folders in the music tree.
e.g. I have the music library sorted by first letter ("/mp3/A/Alanis Morissette/Jagged...") and I want to change that into "/mp3/Alanis Morissette/Jagged..." there stays an empty "A" directory...
Comment 2 Michael Lissner 2008-01-02 04:05:34 UTC
This should also be taken care of when organizing tracks via the Right Click > Manage Files > Organize Files... option. 
Comment 3 Michael Lissner 2008-01-02 04:08:07 UTC
This should also be taken care of when organizing tracks via the Right Click > Manage Files > Organize Files... option. 
Comment 4 Robert Marshall 2008-01-21 10:28:30 UTC
I can confirm this is still a problem with the latest version (1.4.8) in Hardy Heron.
Comment 5 Seb Ruiz 2008-09-08 06:53:04 UTC
I'm 100% sure I implemented this back in 1.4 series: the conditions where, if organising tracks, delete the folder if it was empty _and_ under a collection.

Please reopen if i'm mistaken, I'll take a look to see if it's there for Amarok 2
Comment 6 Christian González 2008-09-08 11:21:16 UTC
No, this doesn't work.
I just did the following:

In Amarok, I went into the folder/file view, picked a single mp3 outside of my collection folder, which is completely new (I don't have this already in my collection) -> right click -> copy to collecction.
The file appears correctly in my collection.
In the Collection tab, navigate to this artist/song, right-click -> manage files -> delete file. Click on the Checkbox to enable completely purging from the harddisk, click ok.
The file is gone, but the artist AND album folders in my collection still exist, empty.
This bug is NOT at all solved.
Comment 7 Mark Kretschmann 2008-09-08 11:30:04 UTC
Christian: However, are you referring to Amarok 2? Cause Amarok 1.x is no longer actively maintained, and thus irrelevant.
Comment 8 Christian González 2008-09-08 11:48:07 UTC
Yes, I am referring to 1.4.9.
If it will not be fixed in Amarok1 because it is unmaintained, the bug still is not WORKSFORME, but either WONTFIX if it is not intended to fix this in Amarok 2, or left as NEw until is clear if it is fixed or not in Amarok2 or not.

And "unmaintained" is strange since
http://amarok.kde.org/de/node/537
says that a bugfix version recently was released, additionally to the fact that You have an unmaintained version then and a beta2 which is not intended for stable use.

I *love* Aamarok, but you should make things clear:
1. If it is fixed in Amarok2 then this big is fixed, ok (I can't test that, Amarok2 nightly build is still to unstable on my Kubuntu hardy)
2. If it is not fixed in A2, or not known if fixed or not, you must leave it open.
3. If I misunderstood something here (in the bugfix behaviour) or am an complete moron ;-), just tell me and close the bug ;-)
Comment 9 Mark Kretschmann 2008-09-08 12:00:42 UTC
Ok I'll just close this, thanks.
Comment 10 Seb Ruiz 2008-09-08 12:20:22 UTC
Just tested, this isn't implemented in Amarok 2
Comment 11 Mark Kretschmann 2008-09-14 15:22:10 UTC
Fixed with SVN commit 860843.
Comment 12 mjinxc 2009-03-28 10:03:01 UTC
I believe this bug is back in 2.0.1. Organize files does not clean up emptied directories. (Supposedly fixed in 2.0Beta 2) Can anyone confirm?

Using Ubuntu 8.10