Bug 140539 - Incorrect default URLs for the validators plugin
Summary: Incorrect default URLs for the validators plugin
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-24 10:26 UTC by Benjamin Niemann
Modified: 2007-03-07 20:27 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
w3c validators fix (1.43 KB, patch)
2007-02-01 12:19 UTC, Konrad Rzepecki
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Niemann 2007-01-24 10:26:04 UTC
Version:           3.5.5 (using KDE KDE 3.5.5)
Installed from:    Debian testing/unstable Packages

The validators plugin (Tools > Validate Web Page) currently uses the following URLs as default:

http://validator.w3.org/check/
http://jigsaw.w3.org/css-validator/validator/
http://validator.w3.org/checklink/

All URLs must be without trailing slash.

It used to work, but recent changes of these services broke this - a cyclic redirect in the markup validator, broken links in css validator and link checker (I think the correct URLs have always been without trailing slash).
Comment 1 Konrad Rzepecki 2007-02-01 12:19:43 UTC
Created attachment 19498 [details]
w3c validators fix

I can confirm this bug (3.5.6). HTML validator won't work at all (some errors
about recursion). CSS validator did't load it's style. Link validator works for
me. All of them seems to work fine without trailing slash, so I create fast fix
( Sorry but I can't check now, if it works. But it's so simple that shouldn't
be any problems. ).

This is patch is for kdeaddons 3.5.6.
Comment 2 Martin Koller 2007-03-07 20:27:29 UTC
SVN commit 640363 by mkoller:

BUG: 140539
CCMAIL: hannibal@megapolis.pl

correct default URLs


 M  +3 -3      validatorsdialog.cpp  


--- branches/KDE/3.5/kdeaddons/konq-plugins/validators/validatorsdialog.cpp #640362:640363
@@ -98,19 +98,19 @@
 
   m_WWWValidatorCB->insertStringList(m_config->readListEntry("WWWValidatorUrl"));
   if (m_WWWValidatorCB->count()==0) {
-    m_WWWValidatorCB->insertItem("http://validator.w3.org/check/");
+    m_WWWValidatorCB->insertItem("http://validator.w3.org/check");
   }
   m_WWWValidatorCB->setCurrentItem(m_config->readNumEntry("WWWValidatorUrlIndex",0));
 
   m_CSSValidatorCB->insertStringList(m_config->readListEntry("CSSValidatorUrl"));
   if (m_CSSValidatorCB->count()==0) {
-    m_CSSValidatorCB->insertItem("http://jigsaw.w3.org/css-validator/validator/");
+    m_CSSValidatorCB->insertItem("http://jigsaw.w3.org/css-validator/validator");
   }
   m_CSSValidatorCB->setCurrentItem(m_config->readNumEntry("CSSValidatorUrlIndex",0));
 
   m_linkValidatorCB->insertStringList(m_config->readListEntry("LinkValidatorUrl"));
   if (m_linkValidatorCB->count()==0) {
-    m_linkValidatorCB->insertItem("http://validator.w3.org/checklink/");
+    m_linkValidatorCB->insertItem("http://validator.w3.org/checklink");
   }
   m_linkValidatorCB->setCurrentItem(m_config->readNumEntry("LinkValidatorUrlIndex",0));