Bug 140364 - I can move the slider while listening to a radio stream
Summary: I can move the slider while listening to a radio stream
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-20 18:51 UTC by Unknown
Modified: 2007-01-28 15:14 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Unknown 2007-01-20 18:51:19 UTC
Version:           amarok-1.4.4-110.guru.suse102 (using KDE KDE 3.5.5)
Installed from:    SuSE RPMs
OS:                Linux

When I listen to a radio stream the slider bar is "disabled" so the marker is not moving.

But Amarok has that feature I can change the actual position of my song when I move the mouse pointer over the Amarok icon on the tray, hold Shift and use the mouse wheel.

It's normal for the local files but unfortunately this method is also working with the stremaing media.
And when I do this the stream goes wrong.
Comment 1 Martin Aumueller 2007-01-28 15:14:01 UTC
SVN commit 627871 by aumuell:

disable seeking in streams
BUG: 140364


 M  +3 -0      ChangeLog  
 M  +5 -2      src/enginecontroller.cpp  


--- trunk/extragear/multimedia/amarok/ChangeLog #627870:627871
@@ -101,6 +101,9 @@
     * Amarok now saves playlists with relative paths by default.
 
   BUGFIXES:
+    * Disable seeking in streams. (BR 140364)
+    * With the default theme, the playlist browser info pane would not show
+      the horizontal scrollbar if necessary. (BR 134221)
     * Some .rm files would make Amarok crash. (BR 137695)
     * Remember 'User Cover Art for Folder Icons' when organizing files.
       (BR 138582)
--- trunk/extragear/multimedia/amarok/src/enginecontroller.cpp #627870:627871
@@ -536,8 +536,11 @@
 
 void EngineController::seek( int ms ) //SLOT
 {
-    trackPositionChangedNotify( ms, true ); /* User seek */
-    engine()->seek( ms );
+    if( bundle().length() > 0 )
+    {
+        trackPositionChangedNotify( ms, true ); /* User seek */
+        engine()->seek( ms );
+    }
 }